unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
* [PATCH] emacs: Fix a notmuch-print.el compiler warning.
@ 2012-01-25  8:52 David Edmondson
  2012-01-25  9:19 ` Tomi Ollila
  2012-01-26 12:27 ` David Bremner
  0 siblings, 2 replies; 5+ messages in thread
From: David Edmondson @ 2012-01-25  8:52 UTC (permalink / raw)
  To: notmuch

`notmuch-show-get-prop' should be declared.
---
 emacs/notmuch-print.el |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/emacs/notmuch-print.el b/emacs/notmuch-print.el
index f96ccbe..fd86288 100644
--- a/emacs/notmuch-print.el
+++ b/emacs/notmuch-print.el
@@ -19,6 +19,8 @@
 ;;
 ;; Authors: David Edmondson <dme@dme.org>
 
+(declare-function notmuch-show-get-prop "notmuch-show" (prop &optional props))
+
 (defcustom notmuch-print-mechanism 'notmuch-print-lpr
   "How should printing be done?"
   :group 'notmuch
-- 
1.7.8.3

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] emacs: Fix a notmuch-print.el compiler warning.
  2012-01-25  8:52 [PATCH] emacs: Fix a notmuch-print.el compiler warning David Edmondson
@ 2012-01-25  9:19 ` Tomi Ollila
  2012-01-25  9:24   ` David Edmondson
  2012-01-26 12:27 ` David Bremner
  1 sibling, 1 reply; 5+ messages in thread
From: Tomi Ollila @ 2012-01-25  9:19 UTC (permalink / raw)
  To: David Edmondson, notmuch

On Wed, 25 Jan 2012 08:52:15 +0000, David Edmondson <dme@dme.org> wrote:
> `notmuch-show-get-prop' should be declared.
> ---

How 'bout 

(require 'notmuch-lib)

and put that declare-function there ?

So that when declaration gets checked when notmuch-show defuns it 


Tomi

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] emacs: Fix a notmuch-print.el compiler warning.
  2012-01-25  9:19 ` Tomi Ollila
@ 2012-01-25  9:24   ` David Edmondson
  2012-01-25 10:35     ` Tomi Ollila
  0 siblings, 1 reply; 5+ messages in thread
From: David Edmondson @ 2012-01-25  9:24 UTC (permalink / raw)
  To: Tomi Ollila, notmuch

[-- Attachment #1: Type: text/plain, Size: 506 bytes --]

On Wed, 25 Jan 2012 11:19:30 +0200, Tomi Ollila <tomi.ollila@iki.fi> wrote:
> On Wed, 25 Jan 2012 08:52:15 +0000, David Edmondson <dme@dme.org> wrote:
> > `notmuch-show-get-prop' should be declared.
> > ---
> 
> How 'bout 
> 
> (require 'notmuch-lib)
> 
> and put that declare-function there ?
> 
> So that when declaration gets checked when notmuch-show defuns it 

That doesn't work, as I recall. A `declare-function' in a `require'd
file has no effect - the compiler will still complain.

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] emacs: Fix a notmuch-print.el compiler warning.
  2012-01-25  9:24   ` David Edmondson
@ 2012-01-25 10:35     ` Tomi Ollila
  0 siblings, 0 replies; 5+ messages in thread
From: Tomi Ollila @ 2012-01-25 10:35 UTC (permalink / raw)
  To: David Edmondson, Tomi Ollila, notmuch

On Wed, 25 Jan 2012 09:24:46 +0000, David Edmondson <dme@dme.org> wrote:
> On Wed, 25 Jan 2012 11:19:30 +0200, Tomi Ollila <tomi.ollila@iki.fi> wrote:
> > On Wed, 25 Jan 2012 08:52:15 +0000, David Edmondson <dme@dme.org> wrote:
> > > `notmuch-show-get-prop' should be declared.
> > > ---
> > 
> > How 'bout 
> > 
> > (require 'notmuch-lib)
> > 
> > and put that declare-function there ?
> > 
> > So that when declaration gets checked when notmuch-show defuns it 
> 
> That doesn't work, as I recall. A `declare-function' in a `require'd
> file has no effect - the compiler will still complain.

Ok

+1

I (might) check how check-declare can be used here...


Tomi

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] emacs: Fix a notmuch-print.el compiler warning.
  2012-01-25  8:52 [PATCH] emacs: Fix a notmuch-print.el compiler warning David Edmondson
  2012-01-25  9:19 ` Tomi Ollila
@ 2012-01-26 12:27 ` David Bremner
  1 sibling, 0 replies; 5+ messages in thread
From: David Bremner @ 2012-01-26 12:27 UTC (permalink / raw)
  To: David Edmondson, notmuch

On Wed, 25 Jan 2012 08:52:15 +0000, David Edmondson <dme@dme.org> wrote:
> `notmuch-show-get-prop' should be declared.

pushed.

d

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2012-01-26 12:27 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-25  8:52 [PATCH] emacs: Fix a notmuch-print.el compiler warning David Edmondson
2012-01-25  9:19 ` Tomi Ollila
2012-01-25  9:24   ` David Edmondson
2012-01-25 10:35     ` Tomi Ollila
2012-01-26 12:27 ` David Bremner

Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).