From: Tomi Ollila <tomi.ollila@iki.fi>
To: david@tethera.net, notmuch@notmuchmail.org
Cc: David Bremner <bremner@debian.org>
Subject: Re: [PATCH 2/3] notmuch-restore: tidy formatting
Date: Thu, 15 Nov 2012 17:21:43 +0200 [thread overview]
Message-ID: <m2mwyix56g.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <1352943202-1431-3-git-send-email-david@tethera.net>
On Thu, Nov 15 2012, david@tethera.net wrote:
> From: David Bremner <bremner@debian.org>
>
> This is again the work of uncrustify.
>
> I remember there is some controversy about "! foo" versus "!foo", but
> in context I think "! foo" looks OK. Also, for functions "! foo
> (blah)" seems better than "!foo (blah)".
Currently:
$ egrep '! ' *.c | wc
19 108 1074
$ egrep '![^ =]' *.c | wc
41 250 2223
Anyway IIRC Carl preferred the ! foo format and the code might
have drifted away from that...
Whatever this choice will eventually be for "pure" notmuch code
should not affect what the code that can be considered as
external libraries should be formatted; e.g. parse-time-string
code should keep the formatting Jani prefers.
The uncrustify.cfg option 'sp_not' affects whether there is
space after ! or not -- and it can even be configured to 'ignore'
this case.
Tomi
// patch dropped.
next prev parent reply other threads:[~2012-11-15 15:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-15 1:33 Uncrustify on notmuch-restore.c, notmuch-dump.c and notmuch-tag.c david
2012-11-15 1:33 ` [PATCH 1/3] notmuch-tag: tidy formatting david
2012-11-15 1:33 ` [PATCH 2/3] notmuch-restore: " david
2012-11-15 15:21 ` Tomi Ollila [this message]
2012-11-15 1:33 ` [PATCH 3/3] notmuch-dump: " david
2012-11-16 12:49 ` Uncrustify on notmuch-restore.c, notmuch-dump.c and notmuch-tag.c David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2mwyix56g.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=bremner@debian.org \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).