From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id A65AC6DE0F6E for ; Thu, 28 Mar 2019 04:34:41 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 0.318 X-Spam-Level: X-Spam-Status: No, score=0.318 tagged_above=-999 required=5 tests=[AWL=-0.336, DKIMWL_WL_MED=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_NEUTRAL=0.652, UNPARSEABLE_RELAY=0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jz8SmWsDHRKA for ; Thu, 28 Mar 2019 04:34:38 -0700 (PDT) Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by arlo.cworth.org (Postfix) with ESMTPS id DB0756DE0F64 for ; Thu, 28 Mar 2019 04:34:37 -0700 (PDT) Received: by mail-wm1-f65.google.com with SMTP id y197so890047wmd.0 for ; Thu, 28 Mar 2019 04:34:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dme-org.20150623.gappssmtp.com; s=20150623; h=to:subject:in-reply-to:references:from:date:message-id:mime-version; bh=jseKqyf80vIxcobXSg68lD4GajYZ2O8bCfhmieRKgOw=; b=1Fnzf3R31ehHwJQnElXAXuM+DFN21Xi5BR3y0GKrKXkxPsIS5ykQ4TgT6od/+6S4ns e9XJFK1VXDwj1anqg/vDgZik6Kk66OC4mKVdmWcWDa9U5UkWlxrQuukVMTgOfgCTFkHf wcEa+HbMUzOmT8rQTvaF0XCo8YUzOTYIqzsQVawdY4hBExynIMsJ4e4LAE1jn+Rp3/0r 1t73xQWkkEGxWechzF0NA3fyMz/I+L0UMQFcaM/6FF2tWtbLfkxXv/d0kxEbLegeWsOa vSt+Xh1jvzsYxC2nUAauJ+O4q7HuFNbYOIE2QkiWd0VRSakeoAg24FFm59NUCsEG2RTk qbUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:subject:in-reply-to:references:from:date :message-id:mime-version; bh=jseKqyf80vIxcobXSg68lD4GajYZ2O8bCfhmieRKgOw=; b=k/HwNqe6I7ibUI0QNQKFhZxKdXHiJ37IX/1lw+qtKCgxIOsPLMaMTqRm8risjt/Tyv UQGsjKcb0BoOZkc5QdJdnTHFUz1BVKIYaB2pO/oFOmtb4GMI+V7sWPdCrgxRsQG7q8p6 NFhhR96/DCuKe4Z7ifWl1fZ6yOksJ5/xrahgpEqMZH0k4Db8BvVncTEYFuxT7EG42mD4 AxKkxNrvCEZ1IGsJ+3ldt5F2aUHXqFaFS1hUOZA8ntbNT2g4rOaN8RJJq1gGui6o4vi8 weAf3j1QSdVg39rGQ8/qX9G+l+j9lJ/Nb1qzECkjx1niBGb1r1fdoH9DinfOW5jEJDzI 3KMg== X-Gm-Message-State: APjAAAXEgGBzpyEXzixAt6F0qRTWuFt/aEmp6jZWGyErGWhgqeFzVplN 6UBBUKIvdSL5srPZy0HyUMDq+A== X-Google-Smtp-Source: APXvYqz9CTVMmB1FD5drIRkCnlgdEptsXgsEsrajpLBX5CjVsLiiFGIfv64nPmXb8XgTAeSrXEGZ6w== X-Received: by 2002:a7b:c04c:: with SMTP id u12mr22691086wmc.71.1553772876168; Thu, 28 Mar 2019 04:34:36 -0700 (PDT) Received: from disaster-area.hh.sledj.net (disaster-area.hh.sledj.net. [81.149.164.25]) by smtp.gmail.com with ESMTPSA id y3sm3560583wmi.27.2019.03.28.04.34.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Mar 2019 04:34:34 -0700 (PDT) Received: from localhost (disaster-area.hh.sledj.net [local]) by disaster-area.hh.sledj.net (OpenSMTPD) with ESMTPA id 44efcd84; Thu, 28 Mar 2019 11:34:34 +0000 (UTC) To: David Bremner , notmuch@notmuchmail.org Subject: Re: [PATCH v1 1/1] emacs: Easy access to URLs mentioned in the current message In-Reply-To: <874l7nz1hi.fsf@tethera.net> References: <20181108104508.84911-1-dme@dme.org> <874l7nz1hi.fsf@tethera.net> X-HGTTG: heart-of-gold From: David Edmondson Date: Thu, 28 Mar 2019 11:34:34 +0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Mar 2019 11:34:41 -0000 On Thursday, 2019-03-28 at 08:23:37 -03, David Bremner wrote: > David Edmondson writes: > > >> +(defun notmuch-show--browse-urls () >> + "Offer to browse any URLs in the current message." >> + (interactive) >> + (let ((urls (notmuch-show--gather-urls))) >> + (if urls >> + (browse-url (completing-read "Browse URL: " (cdr urls) nil nil (car urls))) >> + (message "No URLs found.")))) >> + >> (provide 'notmuch-show) > > It's a minor point, but should this really have -- to signal a private > function? It's bound to key which sortof makes it defacto public, no? Yes. Do you want an updated patch or will you fix it on the fly? dme. -- I'm catching up with myself!