From: David Edmondson <dme@dme.org>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH v1 1/1] emacs: Easy access to URLs mentioned in the current message
Date: Thu, 28 Mar 2019 11:34:34 +0000 [thread overview]
Message-ID: <m2mulfjkqd.fsf@dme.org> (raw)
In-Reply-To: <874l7nz1hi.fsf@tethera.net>
On Thursday, 2019-03-28 at 08:23:37 -03, David Bremner wrote:
> David Edmondson <dme@dme.org> writes:
>
>
>> +(defun notmuch-show--browse-urls ()
>> + "Offer to browse any URLs in the current message."
>> + (interactive)
>> + (let ((urls (notmuch-show--gather-urls)))
>> + (if urls
>> + (browse-url (completing-read "Browse URL: " (cdr urls) nil nil (car urls)))
>> + (message "No URLs found."))))
>> +
>> (provide 'notmuch-show)
>
> It's a minor point, but should this really have -- to signal a private
> function? It's bound to key which sortof makes it defacto public, no?
Yes.
Do you want an updated patch or will you fix it on the fly?
dme.
--
I'm catching up with myself!
next prev parent reply other threads:[~2019-03-28 11:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 10:45 [PATCH v1 1/1] emacs: Easy access to URLs mentioned in the current message David Edmondson
2019-03-28 11:23 ` David Bremner
2019-03-28 11:34 ` David Edmondson [this message]
2019-03-28 13:20 ` David Bremner
2019-03-28 17:41 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2mulfjkqd.fsf@dme.org \
--to=dme@dme.org \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).