From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tomi.ollila@iki.fi>
Received: from localhost (localhost [127.0.0.1])
 by arlo.cworth.org (Postfix) with ESMTP id AE7956DE024F
 for <notmuch@notmuchmail.org>; Tue, 18 Feb 2020 22:32:21 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at cworth.org
X-Spam-Flag: NO
X-Spam-Score: 0.393
X-Spam-Level: 
X-Spam-Status: No, score=0.393 tagged_above=-999 required=5 tests=[AWL=-0.259, 
 SPF_NEUTRAL=0.652] autolearn=disabled
Received: from arlo.cworth.org ([127.0.0.1])
 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id LgwUWr0-2AsT for <notmuch@notmuchmail.org>;
 Tue, 18 Feb 2020 22:32:19 -0800 (PST)
X-Greylist: delayed 363 seconds by postgrey-1.36 at arlo;
 Tue, 18 Feb 2020 22:32:19 PST
Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
 by arlo.cworth.org (Postfix) with ESMTP id 4B6956DE022E
 for <notmuch@notmuchmail.org>; Tue, 18 Feb 2020 22:32:19 -0800 (PST)
Received: from guru.guru-group.fi (localhost [IPv6:::1])
 by guru.guru-group.fi (Postfix) with ESMTP id 670AC1000D0;
 Wed, 19 Feb 2020 08:26:10 +0200 (EET)
From: Tomi Ollila <tomi.ollila@iki.fi>
To: Daniel Kahn Gillmor <dkg@fifthhorseman.net>,
 Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH] Drop deprecated/unused crypto.gpg_path
In-Reply-To: <20200218224257.2552062-1-dkg@fifthhorseman.net>
References: <20200218224257.2552062-1-dkg@fifthhorseman.net>
User-Agent: Notmuch/0.28.3+84~g41389bb (https://notmuchmail.org) Emacs/25.2.1
 (x86_64-unknown-linux-gnu)
X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
 !)g;OY^,BjTbr)Np:%c_o'jj,Z
Date: Wed, 19 Feb 2020 08:26:10 +0200
Message-ID: <m2mu9fdrel.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Use and development of the notmuch mail system."
 <notmuch.notmuchmail.org>
List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Feb 2020 06:32:21 -0000

On Tue, Feb 18 2020, Daniel Kahn Gillmor wrote:

> crypto.gpg_path was only used when we built against gmime versions
> before 3.0.  Since we now depend on gmime 3.0.3 or later, it is
> meaningless.
>
> The removal of the field from the _notmuch_config struct would be an
> ABI change if that struct were externally exposed, but it is not, so
> it's safe to unilaterally remove it.
>
> Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
> ---
>  bindings/python-cffi/tests/conftest.py | 2 --
>  doc/man1/notmuch-config.rst            | 8 --------
>  notmuch-config.c                       | 1 -
>  3 files changed, 11 deletions(-)

All code removal \o/ ! LGTM.

Tomi