From: Tomi Ollila <tomi.ollila@iki.fi>
To: Ludovic LANGE <ll-notmuch@lange.nom.fr>, notmuch@notmuchmail.org
Subject: Re: [PATCH 1/1] python/notmuch2: provide binding for database_get_directory()
Date: Mon, 26 Jul 2021 10:55:34 +0300 [thread overview]
Message-ID: <m2mtq9fr0p.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <c154d820-dbdf-0a49-6967-00a7b6d83aaa@lange.nom.fr>
On Sun, Jul 25 2021, Ludovic LANGE wrote:
// stuff deleted //
> Le 25/07/2021 à 22:18, Floris Bruynooghe a écrit :
// stuff deleted ... //
>>
>> Anyway, I'm curious what other people think of this as well.
>
> Copy/paste (!!) of the previous bindings. As I don't know how people are
> using them, I was expecting to make as little changes as necessary, so
> that code change would be kept to a minimal when porting from old
> bindings to new bindings.
If such an implementation is more inconsistent w/ the new bindings, then
-- for sure -- have implementation that differs more from old bindings.
(and from copy-paste point of view, mistakes lurk easily if changes are
applied w/o doing even more careful post-inspection before committing...)
>
> Waiting for other feedback also.
>
>
>>> + def get_child_files(self):
>> Style-wise I'd name this `def files(self):`, I think it follows the
>> style of the API more.
>
> Same reasoning as before - not wanting to make too much changes from old
> to new bindings.
>
> But if the consensus is on having a new style, we will of course adapt.
IMO the def files(self): (and def directories(self):) are the way to go !
Tomi
// stuff deleted //
>
> Regards,
>
> Ludovic
>
next prev parent reply other threads:[~2021-07-26 7:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-25 8:16 [PATCH 1/1] python/notmuch2: provide binding for database_get_directory() Ludovic LANGE
2021-07-25 20:18 ` Floris Bruynooghe
2021-07-25 20:46 ` Ludovic LANGE
2021-07-26 7:55 ` Tomi Ollila [this message]
[not found] ` <87im0v31z8.fsf@powell.devork.be>
[not found] ` <df94c8da-eba7-f420-8b9a-80b0f6b8a419@lange.nom.fr>
2021-07-31 9:20 ` Floris Bruynooghe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2mtq9fr0p.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=ll-notmuch@lange.nom.fr \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).