From: Tomi Ollila <tomi.ollila@iki.fi>
To: Jameson Graef Rollins <jrollins@finestructure.net>,
Notmuch Mail <notmuch@notmuchmail.org>
Subject: [No Subject]
Date: Sun, 15 Apr 2012 20:23:43 +0300 [thread overview]
Message-ID: <m2lilwsycg.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <1334456272-10376-1-git-send-email-jrollins@finestructure.net>
On Sun, Apr 15 2012, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
> A previous patch [0] replaced blank subject lines with '[No Subject]'
> in search and show mode. Apparently this was needed to circumvent
> some bug in the printing code, but there was no need for it search or
> show, and it is definitely not desirable, so we undo it here (a revert
> is no longer feasible). We should not be modifying strings in the
> original message without good reason, or without a clear indication
> that we are doing so, neither of which apply in this case. For
> further discussion see [0].
>
> [0] id:"1327918561-16245-3-git-send-email-dme@dme.org"
> ---
I agree. LGTM.
Tomi
> Sorry, there was a small bug in the previous version (notmuch-print.el
> was mistakenly modified).
>
> emacs/notmuch-show.el | 5 +----
> emacs/notmuch.el | 5 ++---
> 2 files changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index 30b26d1..1e55099 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -1075,7 +1075,7 @@ function is used."
> (run-hooks 'notmuch-show-hook))
>
> ;; Set the header line to the subject of the first message.
> - (setq header-line-format (notmuch-show-strip-re (notmuch-show-get-pretty-subject)))))
> + (setq header-line-format (notmuch-show-strip-re (notmuch-show-get-subject)))))
>
> (defun notmuch-show-capture-state ()
> "Capture the state of the current buffer.
> @@ -1375,9 +1375,6 @@ current thread."
> (defun notmuch-show-get-depth ()
> (notmuch-show-get-prop :depth))
>
> -(defun notmuch-show-get-pretty-subject ()
> - (notmuch-prettify-subject (notmuch-show-get-subject)))
> -
> (defun notmuch-show-set-tags (tags)
> "Set the tags of the current message."
> (notmuch-show-set-prop :tags tags)
> diff --git a/emacs/notmuch.el b/emacs/notmuch.el
> index ba833e6..326645d 100644
> --- a/emacs/notmuch.el
> +++ b/emacs/notmuch.el
> @@ -507,7 +507,7 @@ Complete list of currently available key bindings:
> "Display the currently selected thread."
> (interactive)
> (let ((thread-id (notmuch-search-find-thread-id))
> - (subject (notmuch-prettify-subject (notmuch-search-find-subject))))
> + (subject (notmuch-search-find-subject)))
> (if (> (length thread-id) 0)
> (notmuch-show thread-id
> (current-buffer)
> @@ -877,8 +877,7 @@ non-authors is found, assume that all of the authors match."
> ;; We currently just throw away excluded matches.
> (unless (eq (aref count 1) ?0)
> (let ((beg (point)))
> - (notmuch-search-show-result date count authors
> - (notmuch-prettify-subject subject) tags)
> + (notmuch-search-show-result date count authors subject tags)
> (notmuch-search-color-line beg (point) tag-list)
> (put-text-property beg (point) 'notmuch-search-thread-id thread-id)
> (put-text-property beg (point) 'notmuch-search-authors authors)
> --
> 1.7.9.5
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2012-04-15 17:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-15 0:08 [PATCH] emacs: do not modify subject in search or show Jameson Graef Rollins
2012-04-15 2:17 ` [PATCH v2] " Jameson Graef Rollins
2012-04-15 17:23 ` Tomi Ollila [this message]
2012-04-29 2:40 ` David Bremner
-- strict thread matches above, loose matches on Subject: below --
2010-03-12 18:46 (no subject) ingmar
2010-03-15 16:22 ` Sebastian Spaeth
2010-03-12 15:43 ingmar
2010-03-12 16:06 ` Sebastian Spaeth
2010-03-11 22:37 Notmuch shared library Ben Gamari
2010-03-12 13:41 ` (no subject) Ingmar Vanhassel
2010-03-15 17:58 ` Ben Gamari
2010-03-12 13:47 ` Ingmar Vanhassel
2010-03-12 15:02 ` Sebastian Spaeth
2010-03-15 16:20 ` Sebastian Spaeth
2009-12-25 19:53 [PATCH] notmuch.el: add a submap (on "z" for "ztash") to stash things david
2009-12-27 3:51 ` (no subject) david
2009-11-25 2:03 Bart Trojanowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2lilwsycg.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=jrollins@finestructure.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).