From: Tomi Ollila <tomi.ollila@iki.fi>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH] contrib: pick: bugfix use of mini-buffer history
Date: Sun, 15 Sep 2013 11:36:19 +0300 [thread overview]
Message-ID: <m2li2ya3cs.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <1379233173-9812-1-git-send-email-markwalters1009@gmail.com>
On Sun, Sep 15 2013, Mark Walters <markwalters1009@gmail.com> wrote:
> pick was meant to use the same mini-buffer history but this failed
> because the interactive definition took place before the use search
> mini-buffer history part. Remove the interactive prompt to ensure the
> correct history is used.
> ---
LGTM.
Tomi
> contrib/notmuch-pick/notmuch-pick.el | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el
> index 01ca4bd..ad85d03 100644
> --- a/contrib/notmuch-pick/notmuch-pick.el
> +++ b/contrib/notmuch-pick/notmuch-pick.el
> @@ -948,7 +948,7 @@ The arguments are:
> BUFFER-NAME: the name of the buffer to show the pick tree. If
> it is nil \"*notmuch-pick\" followed by QUERY is used.
> OPEN-TARGET: If TRUE open the target message in the message pane."
> - (interactive "sNotmuch pick: ")
> + (interactive)
> (if (null query)
> (setq query (notmuch-read-query "Notmuch pick: ")))
> (let ((buffer (get-buffer-create (generate-new-buffer-name
> --
> 1.7.9.1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2013-09-15 8:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-15 8:19 [PATCH] contrib: pick: bugfix use of mini-buffer history Mark Walters
2013-09-15 8:36 ` Tomi Ollila [this message]
2013-09-15 12:07 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2li2ya3cs.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).