Re: elisp + company completion patches, v7

[Tomi Ollila <tomi.ollila@iki.fi>]

On Sun, Oct 25 2015, David Bremner <david@tethera.net> wrote:

> This round contains several bug fixes from Mark, and a slightly
> re-organized initialization from me.  In particular, TAB should now
> behave sanely under company. Also there's a stub
> notmuch-address-message-insinuate to prevent peoples emacs startup
> from failing.

Looks pretty good, I, like Mark, noticed some newline changes in patch 1
(which is fixed in patch 2 so I personally would not care of that). The
another indentation thing Mark noticed is easy to amend.

I, if this does not sound nitpicking, would amend those 'This patch' and
'With this patch' texts in commit messages away by some rewording -- those
pose as a bad example for someone reading the code -- and diminish the
effect when I complain that again in future patched ;)

The basic completion with this new system using notmuch address output
and (supposedly) caching the values seems to work very well and I believe
is welcome feature to (new) users. I did not test how company mode works
as I don't have it (and there is no company mode for this mixed environment
what I use now -- except that I could install it from elpa; maybe I try
that in near future...)

BTW: if anyone knows how to enable lexical-binding to a block of code
(i.e. alternative to -*- lexical-binding: t -*- (or can give hints, like
s/\([^-]\)let/\1lexical-let/) I'd like to know...)

Tomi