unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Tomi Ollila <tomi.ollila@iki.fi>
To: "H. J. Illikainen" <hji@dyntopia.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: Fontify From with message-header-other
Date: Fri, 06 Nov 2015 17:31:38 +0200	[thread overview]
Message-ID: <m2lhab87qd.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <1446677040-43496-1-git-send-email-hji@dyntopia.com>

On Thu, Nov 05 2015, "H. J. Illikainen" <hji@dyntopia.com> wrote:

> Commit e26d767897e8ab59f05808a12ac5c9c1e3c7030f changed the
> fontification of the body associated with the From header to
> message-header-from.  However, that face is non-existent, and in
> message.el (message-font-lock-keywords) the From-header falls through
> and is attributed the message-header-other face.
>
> This commit removes the fontification of the [Ff]rom header in
> notmuch-show-mode in order to fontify it using the message-header-other
> face.
>
> This only affects non-default configurations where
> notmuch-message-headers is set to display From.

I grepped emacs 24.3 sources for message-header-subject and
message-header-from and, indeed, there is not reference to 
message-header-from (but plenty of message-header-subject).

So, to me this change looks good (and trivial) -- I have not
tested it (yet), though.

Tomi

> ---
>  emacs/notmuch-show.el | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index 49fd198..793f1a5 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -353,8 +353,6 @@ operation on the contents of the current buffer."
>  		'message-header-cc)
>  	       ((looking-at "[Ss]ubject:")
>  		'message-header-subject)
> -	       ((looking-at "[Ff]rom:")
> -		'message-header-from)
>  	       (t
>  		'message-header-other))))
>  
> -- 
> H. J. Illikainen
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch

  reply	other threads:[~2015-11-06 15:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-04 22:44 [PATCH] emacs: Fontify From with message-header-other H. J. Illikainen
2015-11-06 15:31 ` Tomi Ollila [this message]
2015-11-09 14:59 ` Mark Walters
2015-11-10  2:31 ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2lhab87qd.fsf@guru.guru-group.fi \
    --to=tomi.ollila@iki.fi \
    --cc=hji@dyntopia.com \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).