From: David Edmondson <dme@dme.org>
To: David Bremner <david@tethera.net>,
notmuch@notmuchmail.org, 759646@bugs.debian.org
Subject: Re: [Vagrant Cascadian] Bug#759646: notmuch-emacs: switching mode= to invalid value sends unencrypted mail
Date: Mon, 08 Feb 2016 17:52:01 +0000 [thread overview]
Message-ID: <m2lh6v3xa6.fsf@heart-of-gold.hh.sledj.net> (raw)
In-Reply-To: <87egsldds6.fsf@maritornes.cs.unb.ca>
[Raking over history...]
On Sat, Nov 29 2014, David Bremner wrote:
> David Edmondson <dme@dme.org> writes:
>
>> On Tue, Sep 02 2014, Tomi Ollila wrote:
>>> On Tue, Sep 02 2014, Daniel Kahn Gillmor <dkg@fifthhorseman.net> wrote:
>>>
>>>> On 08/30/2014 03:37 AM, Jani Nikula wrote:
>>>>> I'm inclined to think this is a bug in message-mode.
>>>>
>>>> I agree it's a bug in message-mode, not in notmuch itself.
>>>
>>> I think it might be here:
>>>
>>> http://bzr.savannah.gnu.org/lh/emacs/emacs-24/annotate/head:/lisp/gnus/mml.el#L258
>>>
>>> (it takes time to load, please wait...)
>>>
>>> If cond does not match, then don't fail...
>>
>> This looks to have been fixed in emacs at the end of September 2014.
>
> Right, this fix was released in emacs 24.4
>
> I'm a little torn what to do here. On the one hand the upstream change
> fixes the bug as reported. On the other hand, if something corrupts the
> #secure tag (e.g., by deleting a letter), then the message is still sent
> un-uncrypted.
That's true, but it's undoubtedly an upstream bug rather than a
notmuch-emacs bug.
If we apply some heuristic workaround in notmuch, users of gnus (and
mu4e?) will still be vulnerable to the same problem. The right thing to
do is report (and fix) the bug upstream.
next prev parent reply other threads:[~2016-02-08 17:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-29 18:05 [Vagrant Cascadian] Bug#759646: notmuch-emacs: switching mode= to invalid value sends unencrypted mail David Bremner
2014-08-30 7:37 ` Jani Nikula
2014-09-02 5:57 ` Daniel Kahn Gillmor
2014-09-02 8:02 ` Tomi Ollila
2014-11-12 20:17 ` David Edmondson
2014-11-29 19:09 ` David Bremner
2014-12-01 6:41 ` David Edmondson
2014-12-01 6:45 ` David Bremner
2014-12-01 7:16 ` David Edmondson
2016-02-08 17:52 ` David Edmondson [this message]
2021-12-26 11:28 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2lh6v3xa6.fsf@heart-of-gold.hh.sledj.net \
--to=dme@dme.org \
--cc=759646@bugs.debian.org \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).