From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tomi.ollila@iki.fi>
Received: from localhost (localhost [127.0.0.1])
 by arlo.cworth.org (Postfix) with ESMTP id 5E0016DE1057
 for <notmuch@notmuchmail.org>; Wed,  8 May 2019 08:55:50 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at cworth.org
X-Spam-Flag: NO
X-Spam-Score: 0.443
X-Spam-Level: 
X-Spam-Status: No, score=0.443 tagged_above=-999 required=5 tests=[AWL=-0.219, 
 SPF_NEUTRAL=0.652, T_SPF_HELO_TEMPERROR=0.01] autolearn=disabled
Received: from arlo.cworth.org ([127.0.0.1])
 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id AAyYf4AKoFMe for <notmuch@notmuchmail.org>;
 Wed,  8 May 2019 08:55:49 -0700 (PDT)
Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
 by arlo.cworth.org (Postfix) with ESMTP id E1DA26DE104E
 for <notmuch@notmuchmail.org>; Wed,  8 May 2019 08:55:48 -0700 (PDT)
Received: from guru.guru-group.fi (localhost [IPv6:::1])
 by guru.guru-group.fi (Postfix) with ESMTP id 5D2791000E3;
 Wed,  8 May 2019 18:55:44 +0300 (EEST)
From: Tomi Ollila <tomi.ollila@iki.fi>
To: Daniel Kahn Gillmor <dkg@fifthhorseman.net>,
 Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH] test: avoid unnecessary extraction of the test
 fingerprint
In-Reply-To: <20190507130135.14898-1-dkg@fifthhorseman.net>
References: <20190507130135.14898-1-dkg@fifthhorseman.net>
User-Agent: Notmuch/0.28.3+84~g41389bb (https://notmuchmail.org) Emacs/25.2.1
 (x86_64-unknown-linux-gnu)
X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
 !)g;OY^,BjTbr)Np:%c_o'jj,Z
Date: Wed, 08 May 2019 18:55:43 +0300
Message-ID: <m2lfzh3pq8.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Use and development of the notmuch mail system."
 <notmuch.notmuchmail.org>
List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Wed, 08 May 2019 15:55:50 -0000

On Tue, May 07 2019, Daniel Kahn Gillmor wrote:

> FINGERPRINT is already exported by add_gnupg_home, so this is
> unnecessary.  This change also happens to get rid of the superfluous
> check-trustdb spew from the test suite that looked like this:
>
> gpg: checking the trustdb
> gpg: marginals needed: 3  completes needed: 1  trust model: pgp
> gpg: depth: 0  valid:   1  signed:   0  trust: 0-, 0q, 0n, 0m, 0f, 1u
>
> Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>

LGTM (just quick glance -- but code removal is always good thing when
possible ! ;)

(I trust dkg knows what he is doing in this matter)

Tomi

> ---
>  test/T357-index-decryption.sh | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/test/T357-index-decryption.sh b/test/T357-index-decryption.sh
> index c9cd5e30..8a2d4c02 100755
> --- a/test/T357-index-decryption.sh
> +++ b/test/T357-index-decryption.sh
> @@ -8,8 +8,6 @@ test_description='indexing decrypted mail'
>  ##################################################
>  
>  add_gnupg_home
> -# get key fingerprint
> -FINGERPRINT=$(gpg --no-tty --list-secret-keys --with-colons --fingerprint | grep '^fpr:' | cut -d: -f10)
>  
>  # create a test encrypted message
>  test_begin_subtest 'emacs delivery of encrypted message'
> -- 
> 2.20.1