From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id IDOoBJnNJmD3VQAA0tVLHw (envelope-from ) for ; Fri, 12 Feb 2021 18:48:57 +0000 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id ODKBAJnNJmCxCwAA1q6Kng (envelope-from ) for ; Fri, 12 Feb 2021 18:48:57 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 82D182C605 for ; Fri, 12 Feb 2021 19:48:55 +0100 (CET) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id C0DA11FF24; Fri, 12 Feb 2021 13:48:46 -0500 (EST) Received: from lahtoruutu.iki.fi (unknown [IPv6:2a0b:5c81:1c1::37]) by mail.notmuchmail.org (Postfix) with ESMTPS id 3A9301FE96 for ; Fri, 12 Feb 2021 13:48:44 -0500 (EST) Received: from guru.guru-group.fi (unknown [IPv6:2a02:2380:1:9:5054:ff:feb7:a4bc]) (using TLSv1.2 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: too) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id AF9EF1B00046; Fri, 12 Feb 2021 20:48:30 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1613155710; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WjSTzoVhsNWVa05lYth9qmES/sl8hkPR8s/sQo0u3LA=; b=vaG9vCXsxqfCLshGvjHz/n61hAG4JfsR4cfwdKKZ9IHbf/8HVJIj5xZVlT5d1LkYGGCj67 y2HquCS0lbr4GWE2oh0UUgn1fiGcr6KIdFnk1ie8Nrk+r4NjMBRRGrP+mcWfJhPSXPs/6v h3u7Oyu239IJ1zWudMipVVGyaFeh6+VpyRy3EkeWvh3z2THTOFt/DDNf9s+Hdk/jqoieXa whbkVWc7HM++SmAA29BDpp7Enf0Ofx58p0Ul0Si6ElnUL4gW7suGtM3hRxaN4zICcQuILV M0zp+izELaNC7R5XjpSrskJCvW6M6QiKsLudok8icYUC+HT5p9CvAYU+5e08wg== From: Tomi Ollila To: Michael J Gruber , notmuch@notmuchmail.org Subject: Re: [PATCH] fix FTBFS with glib In-Reply-To: References: User-Agent: Notmuch/0.31.3+85~g92bd77f (https://notmuchmail.org) Emacs/27.1 X-Face: HhBM'cA~ MIME-Version: 1.0 ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=too smtp.mailfrom=tomi.ollila@iki.fi ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1613155710; a=rsa-sha256; cv=none; b=C/wGGvjIA6+0FC60lim5Zej3wDmk/qg7XrXwPudwELKV1Xvu31r8JDyuuNmJzrK/uNhoSg rADtVWL9KRS4EaeEvPKtccTkyap9YI6fa2tFoVPq03FoIolvdilloa7+Mw7BH5VuddFKgx fTnekKXj2K8tssfYrWo5rtP7/0MjvRHTIiBmquZtDzrvoOWeA/WIBGuv6oVhWAWkOdJ1UQ q45yEJQTELATeia6UkzjiKUedph60qgSCpWVJhBBO3YAL+NWor3qp7bVOkZgCrqciiWR31 cArsV/qsnNq2LUwMTZ1C+eskrntEPiaoEMPuFLPZncAMsuSRgb5jUcTscrrJFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1613155710; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WjSTzoVhsNWVa05lYth9qmES/sl8hkPR8s/sQo0u3LA=; b=A9ufmSkJ4IgBlm9vgC1h+F9pYV5RYVaHOgOdKlPeUa2RBpanDtMZHYHP9HEmc8OVAGZnsY seq46P7ZTK32cvxx5XEJpYI5YMX04DU581RGEhfeFMx4hX6iGUU2X7PfvaBjL7h+0lu1YI 3AItK05sNl3Ybg7izUqm/swdqYhLpJNvkkxiTNXBFCu5vWRD1JNfsBDTuB96wregLV7qhz ofa7q0Zq3hazlcICEszWfRMqROu4FcWcOaUXUArVE79MltKoAmGeOb3VggXvZDZUUVhqjC vz5X/JdTnii8b7s4MlqCpiW20uTv6mkVRcbrNWRz2Tteu+B6in9hB/fr/31jLg== Message-ID-Hash: OMLGBOXRTYEEX53SLOQZC3VQQFLQ4UIU X-Message-ID-Hash: OMLGBOXRTYEEX53SLOQZC3VQQFLQ4UIU X-MailFrom: tomi.ollila@iki.fi X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: 2.52 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=lahtoruutu header.b=vaG9vCXs; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 82D182C605 X-Spam-Score: 2.52 X-Migadu-Scanner: scn0.migadu.com X-TUID: Ns2M7vY8JwUP On Thu, Feb 11 2021, Michael J. Gruber wrote: > With newer glib, notmuch FTBFS because of C linkage error. This is due If/when the alternative change is send (if it works), then it would be nice if this FTBFS were opened (i searched it but deliberately leave it still a mystery for some of us ;) Tomi > to a misplaced include (inside an extern "C") which was always there > but exposed only recently through this change in glib: > > https://gitlab.gnome.org/GNOME/glib/-/merge_requests/1715 > > Move to the include to the outside of the extern block. > > Signed-off-by: Michael J Gruber > --- > lib/notmuch-private.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/notmuch-private.h b/lib/notmuch-private.h > index 2fbf7ab9..46845253 100644 > --- a/lib/notmuch-private.h > +++ b/lib/notmuch-private.h > @@ -31,6 +31,8 @@ > > #include "notmuch.h" > > +#include "gmime-extra.h" > + > NOTMUCH_BEGIN_DECLS > > #include > @@ -47,8 +49,6 @@ NOTMUCH_BEGIN_DECLS > > #include > > -#include "gmime-extra.h" > - > #include "xutil.h" > #include "error_util.h" > #include "string-util.h" > -- > 2.30.0.368.g1c478ce6f6