From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id XsRvLR7RfWCmAAAAgWs5BA (envelope-from ) for ; Mon, 19 Apr 2021 20:51:10 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id iCdmJh7RfWDFZwAA1q6Kng (envelope-from ) for ; Mon, 19 Apr 2021 18:51:10 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E81A7DE84 for ; Mon, 19 Apr 2021 20:51:09 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 5684E271C7; Mon, 19 Apr 2021 14:51:01 -0400 (EDT) Received: from lahtoruutu.iki.fi (lahtoruutu.iki.fi [185.185.170.37]) by mail.notmuchmail.org (Postfix) with ESMTPS id 6446E1F9D5 for ; Mon, 19 Apr 2021 14:50:58 -0400 (EDT) Received: from guru.guru-group.fi (unknown [IPv6:2a02:2380:1:9:5054:ff:feb7:a4bc]) (using TLSv1.2 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: too) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id EF03E1B0004C; Mon, 19 Apr 2021 21:50:54 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1618858255; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GHyMQSiDLJu7D23mTR/pFcIKabHuFN5Vm5Vkyb0PaQU=; b=bu46+fbnSf5PE0r4NuGD878nAm2b/J/FuQrWJfVQXOUzhpNMpgspjJ18bxv8MjizPFaxam R4oM8FpyOVioPvagH2bunOpuaRHH1JHvwJq4efVChG6oCe1umNG0q5hOKIKlmG9nVOYeqU fLNWrliuKdihRwAYdUmx86KEIHEr4P86xbqTdXL/qwTsSWIKkrILTGwAJetZwsl2764Ya9 8+oekKliTn0mMUeCmWSrVZU+CQppBuN4CYoconsATl40AbEOkTNhxanDYs4r/a1wtpLdPt RTW9ClcEMn4EtIIRMyXPzV3Er+oxBlyWmvRFuepVg/ftWQDkloAzNsOoW6U6PQ== From: Tomi Ollila To: David Bremner , Felipe Contreras Subject: Re: [PATCH] ruby: fix ruby 3.1 warnings In-Reply-To: <87k0oy60oe.fsf@tethera.net> References: <20210416202731.72610-1-felipe.contreras@gmail.com> <875z0lcdbd.fsf@tethera.net> <87k0oy60oe.fsf@tethera.net> User-Agent: Notmuch/0.31.4+128~gc67b63a (https://notmuchmail.org) Emacs/27.1 X-Face: HhBM'cA~ MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1618858255; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GHyMQSiDLJu7D23mTR/pFcIKabHuFN5Vm5Vkyb0PaQU=; b=BaZYn7jgztCg/x+59P2NLAiv1GjDnlpfoZj51NfoN+PiiNYPWgW43SuLoVC70MqtthrPX6 HlMtEDiu8YZi5tzggB9i28Fe4BTPpB6xCK4wnXctHcuGtqPnaW6ZfKSkiTOqR6X0693ZXB xpT5HiDQaNEguTV5yFqFncrkbg7ZB+8VsSXkRm+/BXabMN7bOlCIcksSSijFsFTLJH4FCp l0dXBScM2yuyK6Uuaau3vOJqekguVRAWbDYcWb2UwZF5W3cCkkwWAnTk9iweYt/+wcsMib w/xgBnVBkUteO8zFnPE/4Os2AVeq0eqtoggs2Rb3tB54llSHChmyyj359ToPHg== ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=too smtp.mailfrom=tomi.ollila@iki.fi ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1618858255; a=rsa-sha256; cv=none; b=LgQwt45SreiDcNHNPNSRdMfKyLEerXzG9W4YHfZk8uodvB0W1BUsB7QIR+wImDAU7LvutW 8rSXd6oysX2kufelAUnXlBBKATig8K3wiQBLuV3AOeJQTuQSIzogQkZHCOPAf0ORk8pGM8 K7qXPtpbhLYVm9aRKR1OJkiLG4az9U68BMvEazF7Jmft6bO+nUNxZoqtNjHyvINE9g1xQz z9tloX9WkIHLN3PaOWWtDOUA6kO+P3EBHtT/oKnh6lxsXBMxMtymvzvNEEof2B6ur+/rs1 7Ht0bfCPNqsPbNh+NQjQBCDMA3ldknDyBqfLHn5RHVrcunD2kgJ6wdJjsRrxqA== Message-ID-Hash: 37JLNERQZXXT2NQUSGNFHOF3XUNWPWDP X-Message-ID-Hash: 37JLNERQZXXT2NQUSGNFHOF3XUNWPWDP X-MailFrom: tomi.ollila@iki.fi X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: "notmuch@notmuchmail.org" X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1618858270; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=nTDURuOvMDp80bi4MAFbMo69iYTwy5OvnvIH/EUrAww=; b=CexLs3vEiV+9JqDJMyKYFDXodCG4ZmOkvcjChlYkbsyGzLnviCkcdAtWWrevvXxY1sVgfe i8karhpMP4cBjEjW51bcV61cYuOUjlVBmIcu8b2zURRFMv9p8gE/oHGVk8wI+4ezh18tmg NPWx9cYJTT7cfqgXCRAoYDqXEGczWaLV+zEyii4PpPvbMVBNXCoDpMy9aEgqH2nsW0WawU 0Q5yvfaRljehL2QfJ0CDzQsEmH+Vuewzi0W0WnIosPf1XSXCT9fdyPJQr+NPIjqp1uETTe 9UGrULrDC8QZTp3vmFeuo35kDn+zwENmoLrJt21mGvXh1vgydBiDWrLAgVbQMw== ARC-Seal: i=2; s=key1; d=yhetil.org; t=1618858270; a=rsa-sha256; cv=fail; b=WRc57shULtGkej6JEsetG2TkiVrw5Mt/wl5ovWcWCESKH+orwcprq9daz5V/jFdnp4LNWA hHwq62wRRMNU4wL1Ncz8f8wGM1T3S7rJavQ7WzZI64HV/WwVeh/rYJBHLvXJFo5cKK3qJh CHxg+evuWMk8iGGKad+SQm+AX98kKvD0lDTs3pRzW0nKs90jP2jmzI+y/ooPr8W3Tjf8NG qvwbUUjbhF0vHqPMn+JAfniAq3DfxLJtVgtzVko48CeT1Co6ZMAKbC8qi6b64w5U9Em5/y mBQU/Gjc3q7f7IYzWqBnmZ6aub6DIaseKUUvasydm7uFa3GCDsuXXHpRms4pzA== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=lahtoruutu header.b=bu46+fbn; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: 1.07 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=lahtoruutu header.b=bu46+fbn; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: E81A7DE84 X-Spam-Score: 1.07 X-Migadu-Scanner: scn0.migadu.com X-TUID: bMnIwAyCCV+Y On Mon, Apr 19 2021, David Bremner wrote: > Felipe Contreras writes: > >> Hello. >> >> On Sat, Apr 17, 2021 at 7:20 AM David Bremner wrote: >> >>> Thanks for the patch. I have a couple of questions / comments >>> >>> - It doesn't apply against current master (5248f55d5f1). Can you rebase >>> it? >> >> Huh? That's precisely the commit I used as a base. It applies cleanly. >> > > Ah right, you hit an annoying mailman bug related to encodings and line > endings. I have unmangled the patch and applied it to master. ...which is not actually a bug, just features of git and mailman that does not work together... IIRC what happens there: - smtp server receives message encoded as 8bit, possibly only LF (line-feed 0x10) as line endings (I saw this when sent to myself message routed back to me via smtp.iki.fi) - if only LF as line ending, something in pipeline changes that to CRLF (carriage-return line-feed 0x13 0x10) (allowed according to specs) - now (if not before) mailman gets the message, notices it has 8bit encoding, converts that message to have base64 encoding - mailman sends the email now base64-encoded to recipients - user saves message and runs git-am to the message - since content now has CRLF line endings and the content it is comparing to has only NL, the content just does not match. git-am cannot know that (w/o some magical heuristics) that the CRs are actually extra characters should not be there (having CRLF may be as relevant as only LF) In another machine I still have David's email to mailman in one firefox tab; I recall trying to write something there to explain why mailman is buggy there, but eventually could not be convincing enough ;/) git-am could have an option to strip CR's from messages just to overcome the possibility shown above (otoh?) latest git-send-email has this option: --8bit-encoding -- and if not given (and not in git config), according to namual page, will prompt for an encoding (IIRC I've seen this w/ git 2.30) HTH :D Tomi