From: Tomi Ollila <tomi.ollila@iki.fi>
To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2 1/3] mime node: Record depth-first part numbers
Date: Mon, 23 Jan 2012 23:36:38 +0200 [thread overview]
Message-ID: <m2k44i3xuh.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <1327285873-4713-2-git-send-email-amdragon@mit.edu>
On Sun, 22 Jan 2012 21:31:11 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
> This makes the part numbers readily accessible to formatters.
> Hierarchical part numbering would be a more natural and efficient fit
> for MIME and may be the way to go in the future, but depth-first
> numbering maintains compatibility with what we currently do.
> ---
LGTM. I did not understand the logic so after a while I concentrated
on code robustness (i.e. this doesn't break anything). Future
work depends on this.
Tomi
next prev parent reply other threads:[~2012-01-23 21:36 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-18 20:28 [PATCH 0/3] Second step of 'show' rewrite Austin Clements
2012-01-18 20:28 ` [PATCH 1/3] mime node: Record depth-first part numbers Austin Clements
2012-01-18 22:25 ` Jani Nikula
2012-01-19 2:12 ` Austin Clements
2012-01-23 1:02 ` Austin Clements
2012-01-18 20:28 ` [PATCH 2/3] show: Use consistent header ordering in the text format Austin Clements
2012-01-20 13:45 ` Tomi Ollila
2012-01-18 20:28 ` [PATCH 3/3] show: Introduce mime_node formatter callback Austin Clements
2012-01-18 22:33 ` Jani Nikula
2012-01-19 2:23 ` Austin Clements
2012-01-18 20:35 ` [PATCH 0/3] Second step of 'show' rewrite Dmitry Kurochkin
2012-01-18 20:45 ` Austin Clements
2012-01-22 22:44 ` Jameson Graef Rollins
2012-01-23 2:31 ` [PATCH v2 " Austin Clements
2012-01-23 2:31 ` [PATCH v2 1/3] mime node: Record depth-first part numbers Austin Clements
2012-01-23 18:07 ` Jani Nikula
2012-01-23 21:36 ` Tomi Ollila [this message]
2012-01-23 22:19 ` Dmitry Kurochkin
2012-01-23 23:15 ` Austin Clements
2012-01-23 2:31 ` [PATCH v2 2/3] show: Use consistent header ordering in the text format Austin Clements
2012-01-23 2:31 ` [PATCH v2 3/3] show: Introduce mime_node formatter callback Austin Clements
2012-01-23 21:00 ` Tomi Ollila
2012-01-23 22:37 ` Dmitry Kurochkin
2012-01-23 23:23 ` Austin Clements
2012-01-23 20:28 ` [PATCH v3 0/2] Second step of 'show' rewrite Austin Clements
2012-01-23 20:29 ` [PATCH v3 1/2] mime node: Record depth-first part numbers Austin Clements
2012-01-23 20:29 ` [PATCH v3 2/2] show: Introduce mime_node formatter callback Austin Clements
2012-01-23 23:26 ` [PATCH v4 0/3] Second step of 'show' rewrite Austin Clements
2012-01-23 23:26 ` [PATCH v4 1/3] mime node: Record depth-first part numbers Austin Clements
2012-01-23 23:26 ` [PATCH v4 2/3] show: Use consistent header ordering in the text format Austin Clements
2012-01-23 23:26 ` [PATCH v4 3/3] show: Introduce mime_node formatter callback Austin Clements
2012-01-23 23:33 ` [PATCH v5 0/2] Second step of 'show' rewrite Austin Clements
2012-01-23 23:33 ` [PATCH v5 1/2] mime node: Record depth-first part numbers Austin Clements
2012-01-23 23:36 ` Dmitry Kurochkin
2012-01-24 8:57 ` Tomi Ollila
2012-01-23 23:33 ` [PATCH v5 2/2] show: Introduce mime_node formatter callback Austin Clements
2012-01-23 23:36 ` Dmitry Kurochkin
2012-01-24 8:58 ` Tomi Ollila
2012-01-24 18:26 ` Jani Nikula
2012-01-25 11:33 ` [PATCH v5 0/2] Second step of 'show' rewrite David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2k44i3xuh.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=amdragon@MIT.EDU \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).