unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Tomi Ollila <tomi.ollila@iki.fi>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH] contrib: pick: bugfix: use notmuch-show-mark-read-tags instead of unread
Date: Sun, 02 Jun 2013 15:35:45 +0300	[thread overview]
Message-ID: <m2k3mcofku.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <1370123352-13806-1-git-send-email-markwalters1009@gmail.com>

On Sun, Jun 02 2013, Mark Walters <markwalters1009@gmail.com> wrote:

> Previously pick removed the unread tag from its tag display: since the
> tag change is now customisable use the customised variable.
>
> This only affected the tags displayed, not the tags in the database as
> notmuch-show (in the view pane) did the actual tag changes.
> ---
>
> Thanks to Tomi for pointing this out in
> id:m2r4mecofa.fsf@guru.guru-group.fi

LGTM :D

Tomi

>
> Best wishes
>
> Mark
>
>  contrib/notmuch-pick/notmuch-pick.el |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el
> index 128fabf..9079acf 100644
> --- a/contrib/notmuch-pick/notmuch-pick.el
> +++ b/contrib/notmuch-pick/notmuch-pick.el
> @@ -384,7 +384,8 @@ Does NOT change the database."
>  	(with-current-buffer buffer
>  	  (setq notmuch-pick-message-window window)
>  	  (add-hook 'kill-buffer-hook 'notmuch-pick-message-window-kill-hook)))
> -      (notmuch-pick-tag-update-display (list "-unread"))
> +      (when notmuch-show-mark-read-tags
> +	(notmuch-pick-tag-update-display notmuch-show-mark-read-tags))
>        (setq notmuch-pick-message-buffer buffer))))
>  
>  (defun notmuch-pick-show-message-out ()
> -- 
> 1.7.9.1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

  reply	other threads:[~2013-06-02 12:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-01 21:49 [PATCH] contrib: pick: bugfix: use notmuch-show-mark-read-tags instead of unread Mark Walters
2013-06-02 12:35 ` Tomi Ollila [this message]
2013-06-03  0:10 ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2k3mcofku.fsf@guru.guru-group.fi \
    --to=tomi.ollila@iki.fi \
    --cc=markwalters1009@gmail.com \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).