From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id KMGEMpAHg2GMgQEAgWs5BA (envelope-from ) for ; Wed, 03 Nov 2021 23:05:04 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id cDBKLpAHg2GNEAAA1q6Kng (envelope-from ) for ; Wed, 03 Nov 2021 22:05:04 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 59F60264B1 for ; Wed, 3 Nov 2021 23:05:04 +0100 (CET) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 6DE7F1FE09; Wed, 3 Nov 2021 18:04:58 -0400 (EDT) Received: from lahtoruutu.iki.fi (lahtoruutu.iki.fi [185.185.170.37]) by mail.notmuchmail.org (Postfix) with ESMTPS id 5B17B1FDFF for ; Wed, 3 Nov 2021 18:04:56 -0400 (EDT) Received: from guru.guru-group.fi (unknown [IPv6:2a02:2380:1:9:5054:ff:feb7:a4bc]) (using TLSv1.2 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: too) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id BD9351B000E5; Thu, 4 Nov 2021 00:04:54 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1635977094; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VBecRAVYuylxC2d3M5MzfetN/Z/IDEUdbwrqFqQ0uZI=; b=JOvIGvu2dwaW/A24A48ks1+RL6ZdOhARvFdfwndloNdtJmqnRs3gh1NuKt4AKvcgdgE3zb our2bh1f+UqBjZXqsgPvIXWThR853uYw3unCe9IcGA5XABw6F6+vpjfX4Y5FKBxLRKJt+m EYna/Vs2bl33G+lx8tM+EVC3apxXGnZg8YN9e/fWt9ueuKMbNM9lakYP5tnqdZjq530q5G Ny78XmW06lFmDWRTKDl4qGGi/9gfK0MFaiB3kgX+blM+CEwyA0SIX1zjaaBJ7qtw1ieErZ 7/GTndq9GBn5ucezeGJlxgzIkwZV5t23yXncjSXQ9+xDlxm1cpAXArvTk85FZw== From: Tomi Ollila To: David Bremner , "Jorge P. de Morais Neto" , notmuch@notmuchmail.org Subject: Re: [PATCH v2] emacs: drop C-tab binding in hello mode, document . In-Reply-To: <20211030185816.1541058-1-david@tethera.net> References: <20211030183502.1510576-1-david@tethera.net> <20211030185816.1541058-1-david@tethera.net> User-Agent: Notmuch/0.33+54~gcaf4513 (https://notmuchmail.org) Emacs/27.1 X-Face: HhBM'cA~ MIME-Version: 1.0 ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1635977094; a=rsa-sha256; cv=none; b=ZxhNZF1fQ0x809DjylvrQq9XhOjXBy4sd9yDORQ6XBMXEPo/MDu8XbJu6oesZeM4LjIZvq ShyCz+2hS29Y0rWoOd3hRd2JLnjxGLaGtXBiHP0Q4VuIoOCWqX+UvxW7Vi/OAjWKkteMQk wtlDaxZzCSCAS//J1OnRG0fM9votr8ysGeJA2/IUD7VueVvKAc+RCYj2P8RoasQXtrS4kk B/o12G665oP0Z8KNtm8v31dFl3axpjBw9m2GPyRyjYI7A7dQOGDM01ZyR/qanpfzl6EBXn 2NlCG1n5VJUa1R1AiaKsOu2HK3E5mksvBSPjDcGpwsNH64qYWBx3sfO4nIbPdw== ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=too smtp.mailfrom=tomi.ollila@iki.fi ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1635977094; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VBecRAVYuylxC2d3M5MzfetN/Z/IDEUdbwrqFqQ0uZI=; b=kbwy2YMEeFgwD6dmtZ3QAoFAHALBSojuFvYtf1BrN9vRdrdKKas/+631NMmf3LIZA8I4hj X2lLSmfWtmDK0XUKetChgGXEzi7XnX12bqwKkSCJfxVQiMnxpJHUfxHt7eU0XJ1jD1Pghw AZWe5GunAdAj5rriLvpCK0NM2atcHhciTuLpN/S0qxUF2Xc1nZC411fHgSRpHYXOu8kiT6 2m3UiRXLhnaYQsv0ebjHmyXk9Y/+myk+qAw+P1jwYr+Hnk8+ZIxIMQ7kx00mack5Hbv9nt J502N/3nneVpocZKEKVoVnfqubJwe8tK4v2VZGoinbo1IubEsa+/rrVxNIDI9g== Message-ID-Hash: MQ3VMNAQ7JRUMPMJI557E6I5VIG2J47C X-Message-ID-Hash: MQ3VMNAQ7JRUMPMJI557E6I5VIG2J47C X-MailFrom: tomi.ollila@iki.fi X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1635977104; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=tixcRVeT6iKp2PLxx1mMp5L3SOFDwHbg4V+yYYG/K9E=; b=cS4cuiuuqNUgGz7eW6NESH/sh3L5Sbm7mEM5iCABQR73maytrxTQ7S4sNYbRyHlaSmq6aa X6ckcqwxxn2tlzjaXB7QzTbrD13xNIeYDWI/EDBDNra+44K/1DQIguJbpWsb3VcWOF3U4o jnF9xjPT/3RwNg/UrAhZz/JLJG/w4wNYkqM9DG96ldjwAgQ9JdND4jzPf1V9gPrag7S2md no/cVuDNWxOjoWtczC7XHozfX9Cg1KgJLcrsfR4fBQOXa+jENbBZmTCBUJ9TK7mEysDV4h Qgz/DhFqAJEU0zoiNPLryiOE0GLoU/ihsrh4rkrIahNzZ8TxXfjgVnn/x/QHkw== ARC-Seal: i=2; s=key1; d=yhetil.org; t=1635977104; a=rsa-sha256; cv=fail; b=cnZ2lgCWMgkf5lurUJLbss9HC0gNxdJ/y/Z8WpwPReSEzGp4khd/reM+895OfIN65zVNGs 78ibFQo2FxK+etXnVL2/uvUPdsFAJcAyfajJdNMpu8TsTRuJ0kLhm5JdqxfD3yCMgkThYL JyCuGj+kURV3CDN/wyF1eQRqoIsLKpuyFxeyTN6kV2WTlF5vPKN+DtpyhYBvYHVIeyhHlL Cet6Aj0/akmPoYhi4oRB1nL0NaL5zK3JtKdQ+rbkNZ31qZugQYfgNGWn2xgbGWlyiCJsvr 46wEQCyIP+5qUQF+Q5DS2k/i16Cf5N8sC67yCsuyFZ0U3t5stk+skHwORWAsGw== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=lahtoruutu header.b=JOvIGvu2; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: 1.20 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=lahtoruutu header.b=JOvIGvu2; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 59F60264B1 X-Spam-Score: 1.20 X-Migadu-Scanner: scn0.migadu.com X-TUID: qpvFGq3IaTCP On Sat, Oct 30 2021, David Bremner wrote: > The binding has always been there, but the docs were > apparently mistakenly changed to say [1] > > Revert to in the documentation. > > The commit also drops the C- binding, since it seems redundant > and it interferes with tab-bar-mode. > > [1]: 703dec7754da477b5683867c88cb940b8553be91. I am not against :D > --- > doc/notmuch-emacs.rst | 2 +- > emacs/notmuch-hello.el | 1 - > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/doc/notmuch-emacs.rst b/doc/notmuch-emacs.rst > index 12ee25e5..22aee340 100644 > --- a/doc/notmuch-emacs.rst > +++ b/doc/notmuch-emacs.rst > @@ -56,7 +56,7 @@ notmuch-hello key bindings > ```` > Move to the next widget (button or text entry field) > > -```` > +```` > Move to the previous widget. > > ```` > diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el > index 71487bd9..acd48c9b 100644 > --- a/emacs/notmuch-hello.el > +++ b/emacs/notmuch-hello.el > @@ -702,7 +702,6 @@ with `notmuch-hello-query-counts'." > ;; that when we modify map it does not modify widget-keymap). > (let ((map (make-composed-keymap (list (make-sparse-keymap) widget-keymap)))) > (set-keymap-parent map notmuch-common-keymap) > - (define-key map (kbd "") 'widget-backward) > map) > "Keymap for \"notmuch hello\" buffers.") > > -- > 2.33.0