Re: [PATCH v2] emacs: drop C-tab binding in hello mode, document <backtab>.

[Tomi Ollila <tomi.ollila@iki.fi>]

On Sat, Oct 30 2021, David Bremner wrote:

> The <backtab> binding has always been there, but the docs were
> apparently mistakenly changed to say <backspace> [1]
>
> Revert to <backtab> in the documentation.
>
> The commit also drops the C-<tab> binding, since it seems redundant
> and it interferes with tab-bar-mode.
>
> [1]: 703dec7754da477b5683867c88cb940b8553be91.

I am not against :D

> ---
>  doc/notmuch-emacs.rst  | 2 +-
>  emacs/notmuch-hello.el | 1 -
>  2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/doc/notmuch-emacs.rst b/doc/notmuch-emacs.rst
> index 12ee25e5..22aee340 100644
> --- a/doc/notmuch-emacs.rst
> +++ b/doc/notmuch-emacs.rst
> @@ -56,7 +56,7 @@ notmuch-hello key bindings
>  ``<tab>``
>      Move to the next widget (button or text entry field)
>  
> -``<backspace>``
> +``<backtab>``
>      Move to the previous widget.
>  
>  ``<return>``
> diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
> index 71487bd9..acd48c9b 100644
> --- a/emacs/notmuch-hello.el
> +++ b/emacs/notmuch-hello.el
> @@ -702,7 +702,6 @@ with `notmuch-hello-query-counts'."
>    ;; that when we modify map it does not modify widget-keymap).
>    (let ((map (make-composed-keymap (list (make-sparse-keymap) widget-keymap))))
>      (set-keymap-parent map notmuch-common-keymap)
> -    (define-key map (kbd "<C-tab>") 'widget-backward)
>      map)
>    "Keymap for \"notmuch hello\" buffers.")
>  
> -- 
> 2.33.0