From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 26D77431FBF for ; Thu, 8 May 2014 18:20:53 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.3 X-Spam-Level: X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xEQz0ixZkZGd for ; Thu, 8 May 2014 18:20:45 -0700 (PDT) Received: from smtp2.cs.Stanford.EDU (smtp2.cs.Stanford.EDU [171.64.64.26]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 813F5431FAE for ; Thu, 8 May 2014 18:20:45 -0700 (PDT) Received: from chomsky.torservers.net ([77.247.181.162] helo=jane.lan) by smtp2.cs.Stanford.EDU with esmtpsa (UNKNOWN:AES128-GCM-SHA256:128) (Exim 4.80.1) (envelope-from ) id 1WiZUM-0000Zu-Px; Thu, 08 May 2014 18:20:39 -0700 From: Charles Celerier To: David Bremner , Notmuch Mail Subject: Re: [PATCH v2 5/5] T360-symbol-hiding: Use nm instead of objdump. In-Reply-To: <87a9arvs9b.fsf@maritornes.cs.unb.ca> References: <1399395748-44920-1-git-send-email-cceleri@cs.stanford.edu> <1399434615-28425-1-git-send-email-cceleri@cs.stanford.edu> <1399434615-28425-2-git-send-email-cceleri@cs.stanford.edu> <87d2fov2qj.fsf@maritornes.cs.unb.ca> <87a9arvs9b.fsf@maritornes.cs.unb.ca> User-Agent: Notmuch/0.18~rc0+32~gd5092c2 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-apple-darwin13.1.0) Date: Thu, 08 May 2014 21:20:27 -0400 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-Scan-Signature: 127ff6e1eac6b45a32dc112250ed777d X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 May 2014 01:20:53 -0000 --=-=-= Content-Type: text/plain David Bremner writes: > Charles Celerier writes: > >> Here is some of output of the matches made on the output of nm: >> >> $ nm -g test/../lib/*.o | sed -n '/.*\s\+T\s\+_\(notmuch_.*\)/p' >> 00000000000028c0 T _notmuch_database_add_message >> 0000000000002280 T _notmuch_database_begin_atomic >> 0000000000001af0 T _notmuch_database_close >> 0000000000001de0 T _notmuch_database_compact > > With GNU nm, there is no leading _ in front of notmuch here, which is > what causes your version of the test to fail for me. What version of GNU nm are you using? $ nm --version GNU nm (GNU Binutils) 2.24 Copyright 2013 Free Software Foundation, Inc. This program is free software; you may redistribute it under the terms of the GNU General Public License version 3 or (at your option) any later version. This program has absolutely no warranty. I'm not convinced the insertion of an underscore is nm's doing. At this point, I'm not sure how to create a better version of this patch. Are we renaming functions in notmuch-private.h? Should we stick with objdump or switch to using nm? chuck --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) iQEcBAEBAgAGBQJTbC1cAAoJEOjk698fDjuAn0AH/ihbVGsZ60fHoO5ko3WXPnbq 7hxRtjfAbXYhAy3P+mh4+QLHJQpCCd+jOUe0avXPvXotSZ3WehdqoGVSkdXufuX/ TTNrWDaV2iKHnfQgbPY9qxmUnh7X/Ab2q67kq/2zYj0yubinz29HXznpadf3pV5X 7UHhGTs7hX0bKt4i0oo6ZCaA4Xz5GwCQ//PBlAhbP+2ByzIsHeizo9qm3AL2eaDA xUKgagYyFINB3Zj2UHO0gD+qheYq7y1gdEdGdXJxoHPsxAQ80iepyLf1GLXGhSZk RVjEkk7fOqaYkjnB/NDJX+0XVrx8j5+p0+Wxbbiu1PFHywbOzEz6UCiAxWCAL+I= =RmRQ -----END PGP SIGNATURE----- --=-=-=--