From: Tomi Ollila <tomi.ollila@iki.fi>
To: Fraser Tweedale <frase@frase.id.au>, notmuch@notmuchmail.org
Subject: Re: [PATCH 1/2] configure: add a fallback check for zlib
Date: Wed, 21 May 2014 22:34:25 +0300 [thread overview]
Message-ID: <m2ioozori6.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <20140521091304.GT62147@bacardi.hollandpark.frase.id.au>
On Wed, May 21 2014, Fraser Tweedale <frase@frase.id.au> wrote:
> On Sat, May 10, 2014 at 05:27:34PM -0500, Felipe Contreras wrote:
>> Tomi Ollila wrote:
>> > On Sun, May 11 2014, Felipe Contreras <felipe.contreras@gmail.com> wrote:
>> >
>> > > Xīcò wrote:
>> > >> Since zlib is part of the base system, FreeBSD chose not to register it
>> > >> in pkg-config through zlib.pc. As a fallback test, configure will build
>> > >> and run a zlib version check and make sure the header and library
>> > >> versions are compatible.
>> > >
>> > > We could try to generate our on zlib.pc, this way the configure script
>> > > would be cleaner.
>> >
>> > But for that we'd need to figure out the version, and is there simpler
>> > robust way to do that some other way ?
>>
>> I don't meant to change the code that is checking for the version in the
>> patch, you use the same code, but instead of have_zlib.c gen_zlib_pc.c,
>> or something.
>>
>
> [please cc me in replies; I am not subscribed to the list]
>
> I think that the additional complexity outweighs the benefit of a
> somewhat cleaner build script.
>
> If the $vz1, $vz2, et al. are what's bothering you, perhaps we could
> push the complexity of version comparison into have_zlib.c and
> supply the (string) version number as an argument to the program.
> The have_zlib program could do the comparison and exit accordingly,
> and plain old "1.2.5.2" can take its place in the configure script
> once more.
>
> However, I don't see any problems with the patch as it is; I have
> tested it on FreeBSD 10.0 and it works.
Did you notice
http://mid.gmane.org/1399864172-28227-1-git-send-email-felipe.contreras@gmail.com
:D
>
> Regards,
>
> Fraser
>
>> --
>> Felipe Contreras
Tomi
next prev parent reply other threads:[~2014-05-21 19:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-10 20:27 [PATCH 1/2] configure: add a fallback check for zlib Xīcò
2014-05-10 21:13 ` Felipe Contreras
2014-05-10 22:01 ` Tomi Ollila
2014-05-10 22:27 ` Felipe Contreras
2014-05-21 9:13 ` Fraser Tweedale
2014-05-21 19:34 ` Tomi Ollila [this message]
2014-05-21 22:13 ` Fraser Tweedale
2014-05-22 8:15 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2ioozori6.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=frase@frase.id.au \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).