From: Tomi Ollila <tomi.ollila@iki.fi>
To: Sebastian Lipp <bacuh@riseup.net>, Karl Fogel <kfogel@red-bean.com>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el.
Date: Tue, 08 Jul 2014 11:56:55 +0300 [thread overview]
Message-ID: <m2ion844a0.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <87bnt2dy0b.fsf@verb.i-did-not-set--mail-host-address--so-tickle-me>
On Sun, Jul 06 2014, Sebastian Lipp <bacuh@riseup.net> wrote:
> Karl Fogel <kfogel@red-bean.com> writes:
>> Sebastian Lipp <bacuh@riseup.net> writes:
>>>diff --git a/emacs/notmuch-address.el b/emacs/notmuch-address.el
>>>index fa65cd5..ee7b169 100644
>>>--- a/emacs/notmuch-address.el
>>>+++ b/emacs/notmuch-address.el
>>>@@ -113,6 +113,59 @@ to know how address selection is made by default."
>>> (when (notmuch-address-locate-command notmuch-address-command)
>>> (notmuch-address-message-insinuate))
>>>
>>>+;; functions to add sender / recipients to BBDB
>>>+
>>>+(defvar bbdb-get-addresses-headers)
>>
>> I think it's good to include an initial value (even an invalid
>> placeholder one, if the real initialization has not happened yet), and a
>> doc string. C-h f defvar RET will say more about how to do that.
>
> I hope I got that right now. (I've got no real clue of Lisp yet because
> I just recently switched to emacs partly because of notmuch. :)
>
> How about
>
> (defvar bbdb-get-addresses-headers nil
> "List of Addresses to import into bbdb")
>
> ?
>
>> (By the way, this isn't a user-customizeable variable, right? If it
>> were, then `defcustom' would be better than `defvar'.)
>
> As far as I understand it: It's not.
someone(tm) could explain why or why-not this is defvar and not defcustom
(or wice versa) so that I don't have to spend time digging into it
but the bbdb-* looks a bit too generic (goes deep into bbdb "namespace"
in a file not part of bbdb -package)
Tomi
next prev parent reply other threads:[~2014-07-08 8:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-06 18:33 [PATCH] emacs: add missing paren to fix defun in notmuch-address.el Karl Fogel
2013-04-07 13:52 ` David Bremner
2013-04-07 21:50 ` Karl Fogel
2013-04-08 8:16 ` Tomi Ollila
2013-04-08 8:40 ` Jani Nikula
2013-04-08 10:50 ` David Bremner
2013-04-09 1:12 ` Jed Brown
2013-04-09 6:32 ` Tomi Ollila
2013-04-09 11:50 ` David Bremner
2013-04-09 12:12 ` Tomi Ollila
2014-07-04 0:38 ` Sebastian Lipp
2014-07-04 0:56 ` Karl Fogel
2014-07-04 9:25 ` Sebastian Lipp
2014-07-05 18:18 ` Karl Fogel
2014-07-06 20:41 ` Sebastian Lipp
2014-07-07 17:35 ` Karl Fogel
2014-07-06 20:37 ` Sebastian Lipp
2014-07-07 17:40 ` Karl Fogel
2014-07-08 8:56 ` Tomi Ollila [this message]
2014-07-08 17:59 ` Karl Fogel
2014-07-04 16:31 ` Tomi Ollila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2ion844a0.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=bacuh@riseup.net \
--cc=kfogel@red-bean.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).