From: David Edmondson <dme@dme.org>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH v5 3/3] emacs: Bind filter in search to 'l'
Date: Tue, 09 Feb 2016 20:24:38 +0000 [thread overview]
Message-ID: <m2io1x4oop.fsf@dme.org> (raw)
In-Reply-To: <1434182890-8047-4-git-send-email-markwalters1009@gmail.com>
On Sat, Jun 13 2015, Mark Walters wrote:
> Change the key binding for filter (or "limit") in search-mode. This
> gives consistency with the new filter in show-mode, and frees 'f' for
> forward-thread in the future.
Is there a conclusion on this change? The patch itself seems obviously
fine from a code perspective, at issue is more whether it's acceptable
to change the key binding.
The equivalent binding in notmuch-show mode is already "l", and I think
that it makes sense to be consistent (i.e. the change should be
applied).
> ---
> emacs/notmuch.el | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/emacs/notmuch.el b/emacs/notmuch.el
> index 6564816..06e3b94 100644
> --- a/emacs/notmuch.el
> +++ b/emacs/notmuch.el
> @@ -166,7 +166,7 @@ (defvar notmuch-search-mode-map
> (define-key map "o" 'notmuch-search-toggle-order)
> (define-key map "c" 'notmuch-search-stash-map)
> (define-key map "t" 'notmuch-search-filter-by-tag)
> - (define-key map "f" 'notmuch-search-filter)
> + (define-key map "l" 'notmuch-search-filter)
> (define-key map [mouse-1] 'notmuch-search-show-thread)
> (define-key map "*" 'notmuch-search-tag-all)
> (define-key map "a" 'notmuch-search-archive-thread)
> @@ -983,7 +983,7 @@ (defun notmuch-search-toggle-order ()
> (notmuch-search-refresh-view))
>
> (defun notmuch-search-filter (query)
> - "Filter the current search results based on an additional query string.
> + "Filter or LIMIT the current search results based on an additional query string.
>
> Runs a new search matching only messages that match both the
> current search results AND the additional query string provided."
> --
> 2.1.4
next prev parent reply other threads:[~2016-02-09 20:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-13 8:08 [PATCH v5 0/3] Add filter to emacs show mode Mark Walters
2015-06-13 8:08 ` [PATCH v5 1/3] emacs: split notmuch-show-apply-state Mark Walters
2015-06-13 8:08 ` [PATCH v5 2/3] emacs: add a filter option to show Mark Walters
2015-08-04 7:19 ` David Bremner
2015-06-13 8:08 ` [PATCH v5 3/3] emacs: Bind filter in search to 'l' Mark Walters
2015-09-07 6:19 ` Tomi Ollila
2016-02-09 20:24 ` David Edmondson [this message]
2016-02-09 21:04 ` Mark Walters
2016-02-10 8:17 ` Tomi Ollila
2016-02-17 22:44 ` Daniel Kahn Gillmor
2016-02-18 0:24 ` David Bremner
2016-02-18 7:54 ` David Edmondson
2016-02-13 16:45 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2io1x4oop.fsf@dme.org \
--to=dme@dme.org \
--cc=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).