From: Tomi Ollila <tomi.ollila@iki.fi>
To: notmuch@notmuchmail.org
Subject: Re: [PATCH] test: test notmuch insert --folder=""
Date: Thu, 02 Nov 2017 22:24:29 +0200 [thread overview]
Message-ID: <m2inesqvia.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <20171102190857.19252-1-jani@nikula.org>
On Thu, Nov 02 2017, Jani Nikula wrote:
I just wonder why our examples always use the format that is hardest to
write (these 3 being equivalent):
--folder="" requires shift-2:s pressed twice on my keyboard
--folder='' requires press '-key (w/o shift) (twice) on my keyboard
--folder= requires neither
That said, this change LGTM.
Tomi
> Test insert into top level folder.
> ---
> test/T070-insert.sh | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/test/T070-insert.sh b/test/T070-insert.sh
> index f1650e623e35..40519bb2f217 100755
> --- a/test/T070-insert.sh
> +++ b/test/T070-insert.sh
> @@ -132,6 +132,13 @@ output=$(notmuch search --output=files path:Drafts/new)
> dirname=$(dirname "$output")
> test_expect_equal "$dirname" "$MAIL_DIR/Drafts/new"
>
> +test_begin_subtest "Insert message into top level folder"
> +gen_insert_msg
> +notmuch insert --folder="" < "$gen_msg_filename"
> +output=$(notmuch search --output=files id:${gen_msg_id})
> +dirname=$(dirname "$output")
> +test_expect_equal "$dirname" "$MAIL_DIR/new"
> +
> test_begin_subtest "Insert message into folder with trailing /"
> gen_insert_msg
> notmuch insert --folder=Drafts/ < "$gen_msg_filename"
> --
> 2.11.0
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2017-11-02 20:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-14 13:15 [PATCH] cli: allow empty strings for notmuch insert --folder argument Jani Nikula
2017-11-02 19:08 ` [PATCH] test: test notmuch insert --folder="" Jani Nikula
2017-11-02 20:24 ` Tomi Ollila [this message]
2017-11-08 14:50 ` [PATCH] cli: allow empty strings for notmuch insert --folder argument David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2inesqvia.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).