From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>, Michael J Gruber <git@grubix.eu>
Cc: notmuch@notmuchmail.org
Subject: Re: Test suite timing issues?
Date: Sun, 13 Feb 2022 10:29:27 +0200 [thread overview]
Message-ID: <m2iltj2mqg.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <m2wnhzag1p.fsf@guru.guru-group.fi>
On Sun, Feb 13 2022, Tomi Ollila wrote:
> On Sat, Feb 12 2022, David Bremner wrote:
>
>> Tomi Ollila <tomi.ollila@iki.fi> writes:
>>
>>>
>>> Does such a change hide "buggy" functionality ?
>>
>> We mostly don't use add_message, call notmuch new via NOTMUCH_NEW in
>> T050-new.sh. So I think it would mostly not hide bugs in notmuch
>> new. OTOH, I'm surprised the same issues with timestamps don't show up
>> there, if that is really the problem.
>>
>>> Or do we consider notmuch new buggy if it does not notice all new messages
>>> arrived every time ?
>>
>> That's a harder question. Maybe? But I don't know how serious a bug it
>> is for actual users (who often get mail delivered in various concurrent
>> ways).
>
> The bug could be that the filesystem mtime resolution is 1 sec (hmm what
> is the resolution in database?), and 2 emails are delivered to one
> directory during one second -- and at the same time notmuch new is scanning
> emails and found only one of those. then no more emails are delivered to
> that one directory for a while -- so notmuch new does not find those.
>
> (now that I think of it that could happen to me :O -- just very improbable
> (or not, `stat .` outputs Modify: 2022-02-12 22:47:19.550838056 +0200) --
> have to check that timestamp resolution in database).
Looked notmuch-new.c -- time_t (seconds since epoch) is used as timestamp
comparisons (which would indicate the subsecond resolution most fs' provide
is not used)...
... and if so, I wonder why some of our tests are not failing all the time
for everyone...?
Tomi
>
> Tomi
next prev parent reply other threads:[~2022-02-13 8:29 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-11 13:55 Test suite timing issues? Michael J Gruber
2022-02-11 14:04 ` Michael J Gruber
2022-02-12 0:03 ` David Bremner
2022-02-12 13:32 ` Michael J Gruber
2022-02-12 14:30 ` David Bremner
2022-02-12 15:06 ` Tomi Ollila
2022-02-12 15:29 ` David Bremner
2022-02-12 19:40 ` David Bremner
2022-02-12 20:45 ` Tomi Ollila
2022-02-12 20:54 ` Michael J Gruber
2022-02-12 21:09 ` David Bremner
2022-02-12 21:53 ` Michael J Gruber
2022-02-12 22:14 ` Tomi Ollila
2022-02-13 8:29 ` Tomi Ollila [this message]
2022-02-14 14:01 ` David Bremner
2022-02-14 14:48 ` Tomi Ollila
2022-02-14 22:53 ` Tomi Ollila
2022-02-15 8:51 ` Michael J Gruber
2022-02-15 15:18 ` Michael J Gruber
2022-02-16 9:52 ` [PATCH] test: allow to use --full-sync Michael J Gruber
2022-02-16 13:04 ` David Bremner
2022-02-16 15:53 ` Michael J Gruber
2022-02-16 21:17 ` Tomi Ollila
2022-02-16 22:01 ` Tomi Ollila
2022-02-17 12:26 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2iltj2mqg.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=david@tethera.net \
--cc=git@grubix.eu \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).