From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tomi.ollila@iki.fi>
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id C96A7431FBF
	for <notmuch@notmuchmail.org>; Thu, 18 Oct 2012 06:59:18 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
	autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id rmzZdCDqmhLD for <notmuch@notmuchmail.org>;
	Thu, 18 Oct 2012 06:59:18 -0700 (PDT)
Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
	by olra.theworths.org (Postfix) with ESMTP id 05A25431FB6
	for <notmuch@notmuchmail.org>; Thu, 18 Oct 2012 06:59:17 -0700 (PDT)
Received: from guru.guru-group.fi (localhost [IPv6:::1])
	by guru.guru-group.fi (Postfix) with ESMTP id AB19D1000E5;
	Thu, 18 Oct 2012 16:59:20 +0300 (EEST)
From: Tomi Ollila <tomi.ollila@iki.fi>
To: Ethan <ethan.glasser.camp@gmail.com>
Subject: Re: [PATCH v2 3/7] emacs: rename `notmuch-show-toggle-headers' to
 `notmuch-show-toggle-visibility-headers'
In-Reply-To: <CAOJ+Ob2aq8MOwbjpXZ=A7B5zPLVQbgBQxs_c8Sa4duuF2c5jFA@mail.gmail.com>
References: <1327469139-1968-1-git-send-email-pieter@praet.org>
	<1329936214-30959-3-git-send-email-pieter@praet.org>
	<87k3uv9xuo.fsf@betacantrips.com> <877gqo8vx2.fsf@betacantrips.com>
	<m2bog0jehf.fsf@guru.guru-group.fi>
	<CAOJ+Ob2aq8MOwbjpXZ=A7B5zPLVQbgBQxs_c8Sa4duuF2c5jFA@mail.gmail.com>
User-Agent: Notmuch/0.14+51~g62cd13b (http://notmuchmail.org) Emacs/24.2.1
	(x86_64-unknown-linux-gnu)
X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
	!)g;OY^,BjTbr)Np:%c_o'jj,Z
Date: Thu, 18 Oct 2012 16:59:20 +0300
Message-ID: <m2hapr285j.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
Cc: Notmuch Mail <notmuch@notmuchmail.org>, Pieter Praet <pieter@praet.org>
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Oct 2012 13:59:19 -0000

On Thu, Oct 18 2012, Ethan wrote:

> On Thu, Oct 18, 2012 at 5:50 AM, Tomi Ollila <tomi.ollila@iki.fi> wrote:
>
>> On Thu, Oct 18 2012, Ethan Glasser-Camp wrote:
>>
>> > Ethan Glasser-Camp <ethan.glasser.camp@gmail.com> writes:
>> >
>> >> This patch, and its predecessors, all look great to me.
>> >
>> > But a note: many of the first lines in your commit messages ("{show,
>>
>> Hmm, first lines -- IIRC mailman adds those tabs to the subject line -- and
>> those are converted to spaces in git-am (??)
>>
>
> I guess this is called "line folding" and notmuch should be sure to undo
> it, as I guess git-am already does.
>
> https://bugs.launchpad.net/mailman/+bug/265915
>
> I guess I can stop complaining about it ;) Patches 1-3 are probably ready
> then. Thanks, Tomi.

Np. Tests pass and the function name change is trivial. 
Removed needs-review on these 3 patches.

> Ethan

Tomi