From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH] test: use test_expect_equal for PATH test, update message
Date: Sun, 13 Apr 2014 15:49:06 +0300 [thread overview]
Message-ID: <m2ha5xv1h9.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <1397392969-8735-1-git-send-email-david@tethera.net>
On Sun, Apr 13 2014, David Bremner <david@tethera.net> wrote:
> - The old test was quite impossible to debug; the new one shows the difference
> between the two directories, if any.
>
> - "repository" doesn't make sense for out of tree builds. Or tarball
> builds, for that matter.
> ---
Looks better than the old one. +1
Tomi
>
> I was tracking down a weird issue with out of tree builds. I didn't
> find the issue (it may have just been cruft from a previously broken
> build). In any case, I think the patch is a small improvement.
>
> test/T000-basic.sh | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/test/T000-basic.sh b/test/T000-basic.sh
> index 9c94b62..ebbb6d2 100755
> --- a/test/T000-basic.sh
> +++ b/test/T000-basic.sh
> @@ -86,8 +86,9 @@ test_expect_success \
> 'NOTMUCH_CONFIG is set and points to an existing file' \
> 'test -f "${NOTMUCH_CONFIG}"'
>
> -test_expect_success \
> - 'PATH is set to this repository' \
> - 'test "`echo $PATH|cut -f1 -d: | sed -e 's,/test/valgrind/bin$,,'`" = "`dirname ${TEST_DIRECTORY}`"'
> +test_begin_subtest 'PATH is set to build directory'
> +test_expect_equal \
> + "$(dirname ${TEST_DIRECTORY})" \
> + "$(echo $PATH|cut -f1 -d: | sed -e 's,/test/valgrind/bin$,,')"
>
> test_done
> --
> 1.9.1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2014-04-13 12:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-13 12:42 [PATCH] test: use test_expect_equal for PATH test, update message David Bremner
2014-04-13 12:49 ` Tomi Ollila [this message]
2014-04-17 22:59 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2ha5xv1h9.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).