Tests failing on master

Tests failing on master

[Johan Parin]

In order to be able to run some tests and since OS X Mojave only has
bash 3.2, I installed a Kali vm, downloaded a fresh notmuch repo,
installed the dependencies and did make test. Result:

1123/1128 tests passed.
3 broken tests failed as expected.
2 tests failed.

More details:

T050-new: Testing "notmuch new" in several variations
 FAIL   Xapian exception: read only files
	--- T050-new.35.expected	2019-11-17 10:05:48.060026443 +0000
	+++ T050-new.35.output	2019-11-17 10:05:48.060026443 +0000
	@@ -1 +1,17 @@
	-A Xapian exception occurred opening database

T150-tagging: Testing "notmuch tag"
 FAIL   Xapian exception: read only files
	--- T150-tagging.25.expected	2019-11-17 10:05:57.536026481 +0000
	+++ T150-tagging.25.output	2019-11-17 10:05:57.536026481 +0000
	@@ -1 +1 @@
	-A Xapian exception occurred opening database
	+

Can anyone confirm / deny that this should occur on master?

I looked at the tests/README and installed the prerequisite packages,
and also downloaded the test databases.


/Johan

Re: Tests failing on master

[Johan Parin]

Johan Parin <johanparin@gmail.com> writes:

> In order to be able to run some tests and since OS X Mojave only has
> bash 3.2, I installed a Kali vm, downloaded a fresh notmuch repo,
> installed the dependencies and did make test. Result:
>
> 1123/1128 tests passed.
> 3 broken tests failed as expected.
> 2 tests failed.
>

I tried on another machine running Ubuntu Server 18.04.3, and there all
1128 tests minus the broken ones passed.

Could the failures on Kali be related to me running as root?


/Johan

Re: Tests failing on master

[David Bremner]

Johan Parin <johanparin@gmail.com> writes:

> Johan Parin <johanparin@gmail.com> writes:
>
>> In order to be able to run some tests and since OS X Mojave only has
>> bash 3.2, I installed a Kali vm, downloaded a fresh notmuch repo,
>> installed the dependencies and did make test. Result:
>>
>> 1123/1128 tests passed.
>> 3 broken tests failed as expected.
>> 2 tests failed.
>>
>
> I tried on another machine running Ubuntu Server 18.04.3, and there all
> 1128 tests minus the broken ones passed.
>
> Could the failures on Kali be related to me running as root?

Yes, being root would break some of the tests, e.g. those that rely on
removing permissions to generate an error. Probably we should just
document that running the test suite as root is not supported? If
someone can explain a good reason to run as root (maybe some odd
auto-builder, the tests in question could probably be modified to do
something more extreme (e.g. delete a file) rather than chmod.

cheers,

d

Re: Tests failing on master

[Tomi Ollila]

On Sun, Nov 17 2019, David Bremner wrote:

> Yes, being root would break some of the tests, e.g. those that rely on
> removing permissions to generate an error. Probably we should just
> document that running the test suite as root is not supported? If
> someone can explain a good reason to run as root (maybe some odd
> auto-builder, the tests in question could probably be modified to do
> something more extreme (e.g. delete a file) rather than chmod.

Yes, rootless podman containers!

if I run e.g

  $ podman run --rm -it -v $HOME:$HOME -w $HOME/vc/ext/notmuch \
         notmuch-buildenv-debian10: /bin/zsh

  [root@e489c80816a9 notmuch]# id
  uid=0(root) gid=0(root) groups=0(root)

  [root@e489c80816a9 notmuch]# pwd
  /home/too/vc/ext/notmuch

  [root@e489c80816a9 build]# ls -l configure 
  -rwxr-xr-x. 1 root root 41920 Nov 17 21:00 configure

  [root@e489c80816a9 build]# exit

  $ ls -l $HOME/vc/ext/notmuch/configure
  -rwxr-xr-x. 1 too too 41920 Nov 17 23:00 /home/too/vc/ext/notmuch/configure

  $ podman unshare cat /proc/self/uid_map
  0       1000          1
  1     100000      65536


The last line, would have had same results if run inside container, tells
that uid 0 (root) inside container was mapped to uid 1000 (too) outside, 
on "host" side, and 1 uid was mapped, from uid 1 onwards in container,
uids are mapped starting from 100000 outside.

All that means, that I can do, without sudo, all kinds of things when 
using this container technology. Files owned by my uid outside container
are seen as owned by root inside container.

Since last spring, I've been gradually moving all things I used docker
to podman. And everything has (in my use cases) worked better. In Fedora
it just works (already). In Ubuntu 16.04 and RHEL 7.7 it also worked when
I tried, but lack of fuse-overlayfs makes it slow (to start) in these
systems. I hope every system in 2020 has good podman support...


All that long text written, I can take care notmuch tests can be run on
podman containers... 

>
> cheers,
>
> d

YEA,

Tomi