Re: [PATCH] emacs: Add notmuch-show-local-dates option

[Kevin Foley <kevin@kevinjfoley.me>]

Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:

> But, setting this to t hides the sender's TZ from the viewer -- and i
> often find it useful to learn the sender's TZ from the Date: header.
>
> What would be really useful for me is to see the Date header represented
> both ways: in my local time *and* the Date header that the sender sent.
> But a boolean setting doesn't give me much room to express that
> preference.

Good point, this is something I hadn't considered but I agree would be
useful to allow.

> This comment says "time", but the emacs config variable name says
> "dates".  This confusion is worse because the Date: header actually
> contains a timestamp, not a date ☹
>
> Perhaps we should rename the variable notmuch-show-date-header-localtime,

I struggled with a name for the reasons you listed =), I think your
proposed name is much clearer and will use that. 

> and it could take three values:
>
>  - nil (default), shows the Date: header as received
>  - t, shows the timestamp from the Date: header in local time, 
>    with the as-received header in parens afterward (see below)
>  - "only", shows only the timestamp in localtime
>

I feel like "only" makes more sense as the option to be used for t, and
having "both" as another option.

> so if your system is TZ=UTC, and notmuch-show-date-header-localtime is
> set to t, and you're looking at a message sent from TZ=America/New_York,
> you might see:
>
> Date: Thu, 02 Jul 2020 19:34:53 +0000 (Thu, 02 Jul 2020 15:34:53 -0400)

Actually, seeing it written out here makes me realize some people could
potentially prefer:

Date: {sent-tz-datetime} ({system-tz-datetime})

or some other kind of formatting.

Would it make sense to allow a function instead of "both", which would
be passed the time and let the user return it formatted how they would
like?  Or is that over-complicating things?

Kevin


_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org