From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>,
Daniel Kahn Gillmor <dkg@fifthhorseman.net>,
David Bremner <david@tethera.net>,
Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH] doc: add dep. on stamp file for rebuilding gzipped man pages.
Date: Sat, 25 Dec 2021 11:39:34 +0200 [thread overview]
Message-ID: <m2h7axyqeh.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <20211224162031.2277841-1-david@tethera.net>
On Fri, Dec 24 2021, David Bremner wrote:
> In [1] Daniel observed that the gzipped man pages were only being
> rebuild every second time when building with `make -j4'. This may be
> caused by a race condition between sphinx-build rebuilding the roff
> files and the recipe to gzip them. This commit sequentializes these
> two steps by making the stamp file a prerequisite for (all of) the
> gzip files.
>
> [1]: id:87tveotn1g.fsf@fifthhorseman.net
> ---
> doc/Makefile.local | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/doc/Makefile.local b/doc/Makefile.local
> index c2ae1743..d43ef269 100644
> --- a/doc/Makefile.local
> +++ b/doc/Makefile.local
> @@ -117,6 +117,11 @@ build-man:
> install-man:
> @echo "No sphinx, will not install man pages."
> else
> +
> +# it should be safe to depend on the stamp file, because it is created
> +# after all roff files are moved into place.
> +${MAN_GZIP_FILES}: ${DOCBUILDDIR}/.roff.stamp
> +
This thread becomes hard to follow...
... but the change looks sensible... the comment *should* be more
"assuritive" though ... :D
> build-man: ${MAN_GZIP_FILES}
> install-man: ${MAN_GZIP_FILES}
> mkdir -m0755 -p "$(DESTDIR)$(mandir)/man1"
> --
> 2.34.1
next prev parent reply other threads:[~2021-12-25 9:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-20 20:43 subsequent rebuilds of notmuch always re-build sphinx and ruby Daniel Kahn Gillmor
2019-04-21 0:12 ` David Bremner
2019-04-21 3:14 ` Daniel Kahn Gillmor
2019-04-21 19:29 ` David Bremner
2019-04-22 23:19 ` Daniel Kahn Gillmor
2019-04-23 0:03 ` David Bremner
2019-04-23 21:43 ` Daniel Kahn Gillmor
2019-04-24 1:09 ` David Bremner
2019-04-24 5:11 ` Daniel Kahn Gillmor
2021-12-24 16:20 ` [PATCH] doc: add dep. on stamp file for rebuilding gzipped man pages David Bremner
2021-12-25 9:39 ` Tomi Ollila [this message]
2021-12-25 11:37 ` David Bremner
2021-10-30 20:48 ` Add stamp files to prevent rebuilds David Bremner
2021-10-30 20:48 ` [PATCH 1/3] doc: introduce stamp file for info build David Bremner
2021-10-30 20:48 ` [PATCH 2/3] ruby: don't use a directory as a target David Bremner
2021-10-30 20:48 ` [PATCH 3/3] python-cffi: introduce stamp file David Bremner
2021-12-04 23:44 ` Add stamp files to prevent rebuilds David Bremner
2021-12-04 23:47 ` [PATCH 1/2] doc: replace phony target with variable David Bremner
2021-12-04 23:47 ` [PATCH 2/2] doc: introduce stamp file for info build David Bremner
2021-12-23 12:24 ` [PATCH 1/2] doc: replace phony target with variable David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2h7axyqeh.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=david@tethera.net \
--cc=dkg@fifthhorseman.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).