From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id KLuFMkJmEWId+wAAgWs5BA (envelope-from ) for ; Sat, 19 Feb 2022 22:50:58 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id iOngL0JmEWJ6hAEA9RJhRA (envelope-from ) for ; Sat, 19 Feb 2022 22:50:58 +0100 Received: from mail.notmuchmail.org (yantan.tethera.net [IPv6:2a01:4f9:c011:7a79::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4C2EF40200 for ; Sat, 19 Feb 2022 22:50:58 +0100 (CET) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 4E31B5F5DE; Sat, 19 Feb 2022 21:50:56 +0000 (UTC) Received: from lahtoruutu.iki.fi (lahtoruutu.iki.fi [185.185.170.37]) by mail.notmuchmail.org (Postfix) with ESMTPS id 6F7585E017 for ; Sat, 19 Feb 2022 21:50:53 +0000 (UTC) Received: from guru.guru-group.fi (unknown [IPv6:2a02:2380:1:9:5054:ff:feb7:a4bc]) (using TLSv1.2 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: too) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id B96611B001CF; Sat, 19 Feb 2022 23:50:52 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1645307452; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GhIqyf8VRqCUPPY0yRjIvph0r5cyJhbGn7p3Jl78KEQ=; b=Ut13cccdi5X93qrbMwOKD2v1fj4U9rwbs0GFj2yjtsDr6ymIJF5div07aXATLQk47FQuuI bcbWK9hN6rxHabj2j8cijUdeIhD00ZjUre96W/S6X3gPq3f07gNSOAW52WKprO9yl4+Ak5 b94kgrow+uNI31TJ7HmpARIZSNGDLLS0Fn3lVTxcngNPEJ0JHvUv/L6JbgWt1j8ECS+t7B vee2Bnx89ODzGloMyznaizEvT+dOYtfEWHQ23H9njzYGR5ZNO8/FzGBimn9Aat9Z/0tXfR vI7Qg1+cfIrY0sjCq94XLDaoE2qqxd99c+xBwI9OAGZhghqruevqBNBW5iqUfw== From: Tomi Ollila To: David Bremner , Michael J Gruber , notmuch@notmuchmail.org Subject: Re: [PATCH 2/4] test: due not pass T380.1 for the wrong reasons In-Reply-To: <87y22fx1d9.fsf@tethera.net> References: <8d483901f3cf9bee86d7359ff1d665943adcd31b.1644406756.git.git@grubix.eu> <87pmnvzo3b.fsf@tethera.net> <164449061694.6325.1611477846768874524.git@grubix.eu> <87y22fx1d9.fsf@tethera.net> User-Agent: Notmuch/0.35+4~ge2bb4cd (https://notmuchmail.org) Emacs/27.1 X-Face: HhBM'cA~ MIME-Version: 1.0 ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=too smtp.mailfrom=tomi.ollila@iki.fi ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1645307452; a=rsa-sha256; cv=none; b=MTOZQb7DDju4N0o4FaB58R4/UaApxlRVIVTGcCOwZ/0/LO/k8E60Mvix0fAEf5iWa5u7fV w5JoA1uu4B0SuY5lCiA6GZSHUCn5PO5KQuGI6IH0sZvnsdK236+r/S/FJfdFUHqtBQDeXq T3gq3EhMl+Wv6e/6ttgRFwhLtwtctrvRvSV9kixe1DvMKGUAYXNTodfOh2fixyEoIyUFNw RXzSltJYTOWIsptWgeHsI5a/xnZEovHiDe8uSGpnPOlV1z/ojgfxkWz61PUtHUpIxC0v5P UvaP/3Ba1AuOhl4PvMy/My6E7p0kLwjJDno2RCiVDOA/SykJSi4Z+SrwmQA/rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1645307452; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GhIqyf8VRqCUPPY0yRjIvph0r5cyJhbGn7p3Jl78KEQ=; b=TRoMVd8fv9SytwhOvCMTRkYHVhTaKgXFfmajNvAjJdupTouszV9MUr0mvn7PhA/DKHYPPs oIhm21xHWsgXIn1bP7U+eiTaCXVHQjD2kpDgtC68PFGV4+q61PXL7t00LsZJDNVgHozZKo LeEUjVfpv4waU75Aqhizu+mAUpdO6J85Cm8vtCLfyq0lUlxCOxTdooxL4gq9z/Gh9AD9vK BNj59WHlyyMLDiP//O7TLWCRuYZqsl1nwssAV6bRfHXq/HJxrDBACvFgtrSLpTm1eNXz0i sb+jJm+QM6qaTyFVZgToexFoD8NnAk4Ayzg4zvFKy/n13AmS4c+JN7wjQyvAoA== Message-ID-Hash: M6UI2IONMCUEMXJFJWCYG43KPHTW7EA5 X-Message-ID-Hash: M6UI2IONMCUEMXJFJWCYG43KPHTW7EA5 X-MailFrom: tomi.ollila@iki.fi X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Country: DE ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1645307458; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=ZMpTG+Q61A1PXl/IO3Vepnh1rdOwW5NYLrwTPuG1UDc=; b=TJkNXjqWnYdcFFcpmUSOpoep/aLnkBk8Qp1XZFMVPTthf91vNHtDTTbpHIjAvK2blhkctO ia8BtpORVHC5QilpC8otVDxTcZLw0Sf/JvJDeNChiYOJxuwQz1i4kAa/Il/BwVFi68RLxC pohUQtzkNhdO07v+PEEWYYPUeaQo0j2zpEDhPJrtY33S9NwXIsh+0AzEQ/pyX3wYsqsqf/ 1cQ5mdj9uWArDnUXZ1onC1ejthKvgy1024mFV3GW6tMgGyE8AWL7Q480j0l5c2GfH8PKb9 8k2j7FtDcfK3wnK9uz/Y9ODirbK9yexq1hogPC6lTmqBRhzn4pm1PujNcNsLqw== ARC-Seal: i=2; s=key1; d=yhetil.org; t=1645307458; a=rsa-sha256; cv=fail; b=a2/PmmWpOA5fPfIVUWyDHqik/bXCUBLBV5PsgsxTmPlZsBZtEI8BYu6cKFvU847CH/oKO5 hL3/LQy8JPTaHlGJ8BHmFBP1mfy6YRmEJGBUALcWk7xY6dVLeQuMP0eUL45forZ985yeUl RWOIrzmT1hasqkaEV8oeuqNOr1sc/y/afHFpLEYMnhwG+rGHOkwXw68qHOIm+iAiVBtQ/e st2hVRROCGEKqqo9FUf3Kdi6eKPf2DkTD8U6y7aJymLPl92+5c4VOOa6NysPVbRII//K+c h1Sa0cQMrpTh19LLTl6jGTr32rvr5cim7y1gJcKibMPBYiXxvImiio16Grx6hQ== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=lahtoruutu header.b=Ut13cccd; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -0.45 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=lahtoruutu header.b=Ut13cccd; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 4C2EF40200 X-Spam-Score: -0.45 X-Migadu-Scanner: scn1.migadu.com X-TUID: FzXchTrQ5x7z On Sat, Feb 12 2022, David Bremner wrote: > Michael J Gruber writes: > > >> When analysing this, I was confused by the way >> test_require_external_prereq works and the "if" in T380 (as opposed to how >> test_require_external_prereq is used in other tests). Over at git.git, >> we have test setup code in functions which don't get executed if >> prerequisites fail. I guess the "if" emulates that, but then the actual >> tests in T380 are outside the if block and use files and variables which >> are created in the if block. So, this is something to fix anyways. > > agreed. > >> Add to this the fact that the tests needing sfsexp or asan (and probably >> others) do things yet differently and call "test_done" immediately, so >> that no SKIP appears. And those were the only ones skipped at all here ... >> > > I think that's probably my fault for also not really understanding the > prereq system. > > >> In the short run, initialising variables and files which are used is >> still a good thing, but I would have to rewrite some commit messages. > > sure. > >> I'll wait until it's clear how to handle style, though: switch to printf >> from echo whenever I touch those lines (leading to mixed use) or keeing >> style and leaving the style change for another series. > > I think I lean to fixing the usage of echo -n incrementally (i.e. don't > introduce more). It might be a bit uglier in the short term, but > eventually we'll get there. If there currently is zero printf's and only echo, I'd personally continue to use echos -- but either way is ok by me > It turns out that echo is _not_ builtin in bash, so this really is a > portability bug. Wat? afaik echo is builtin in every modern bourne shell derivative... (I tested: $ bash -c 'builtin echo foo' foo $ bash -c 'export PATH=/tmp; echo foo; ls' foo bash: ls: command not found ) Tomi > > d