From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>,
Adam Wolfe Gordon <awg+notmuch@xvx.ca>,
notmuch@notmuchmail.org
Subject: Re: [PATCH] test: Force reply to use html2text for consistency
Date: Mon, 07 May 2012 09:17:40 +0300 [thread overview]
Message-ID: <m2fwbc4irf.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <87aa1kj29g.fsf@zancas.localnet>
On Mon, May 07 2012, David Bremner <david@tethera.net> wrote:
> Adam Wolfe Gordon <awg+notmuch@xvx.ca> writes:
>
>> The output of the HTML reply test in the emacs suite can vary
>> depending on which HTML renderers are installed on the machine running
>> the tests. The renderer that is always available is emacs's builtin
>> html2text function. In order to get consistency, force the test to use
>> html2text even if other renderers are available.
>
> pushed, and it seems to replicate the test results on the buildbot. If
> html2text ever gets less crappy I guess we'll have to redo the test
> data.
If html2text ever gets less crappy then we face the same problem -- users
with different emacs get different rendering output making tests fail
for some users.
Then we can do "(let ... (mm-text-html-renderer 'mm-insert-part))
to get html inserted unmodified; excerpt from test output using above:
-> Hi,This is an HTML test message.OK?
+> Hi,<br />This is an <b>HTML</b> test message.<br /><br />OK?
>
> d
Tomi
prev parent reply other threads:[~2012-05-07 6:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-05 19:24 [PATCH v2 0/2] Replying to HTML-only emails, v2 Adam Wolfe Gordon
2012-05-05 19:24 ` [PATCH v2 1/2] test: Replying to an HTML-only message in emacs Adam Wolfe Gordon
2012-05-05 19:24 ` [PATCH v2 2/2] emacs: Correctly quote non-text/plain parts in reply Adam Wolfe Gordon
2012-05-05 19:30 ` [PATCH v2.1 " Adam Wolfe Gordon
2012-05-05 22:30 ` [PATCH v2 0/2] Replying to HTML-only emails, v2 Austin Clements
2012-05-06 12:12 ` David Bremner
2012-05-06 14:29 ` Adam Wolfe Gordon
2012-05-06 14:56 ` [PATCH] test: Force reply to use html2text for consistency Adam Wolfe Gordon
2012-05-06 23:52 ` David Bremner
2012-05-07 6:17 ` Tomi Ollila [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2fwbc4irf.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=awg+notmuch@xvx.ca \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).