From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tomi.ollila@iki.fi>
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id AAAC1431FBD
	for <notmuch@notmuchmail.org>; Sun, 26 Jan 2014 03:18:24 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
	autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id ec3QXsHvpZx1 for <notmuch@notmuchmail.org>;
	Sun, 26 Jan 2014 03:18:17 -0800 (PST)
Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
	by olra.theworths.org (Postfix) with ESMTP id 38286431FBC
	for <notmuch@notmuchmail.org>; Sun, 26 Jan 2014 03:18:17 -0800 (PST)
Received: from guru.guru-group.fi (localhost [IPv6:::1])
	by guru.guru-group.fi (Postfix) with ESMTP id E3188100051;
	Sun, 26 Jan 2014 13:18:12 +0200 (EET)
From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [RFC PATCH] configure: check for POSIX.1-2008 realpath(3)
 implementation.
In-Reply-To: <871tzvo92w.fsf@zancas.localnet>
References: <1390687142-16401-1-git-send-email-tomi.ollila@iki.fi>
	<871tzvo92w.fsf@zancas.localnet>
User-Agent: Notmuch/0.17+41~g8e7fabf (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-unknown-linux-gnu)
X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
	!)g;OY^,BjTbr)Np:%c_o'jj,Z
Date: Sun, 26 Jan 2014 13:18:12 +0200
Message-ID: <m2fvobuh3f.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Sun, 26 Jan 2014 11:18:24 -0000

On Sun, Jan 26 2014, David Bremner <david@tethera.net> wrote:

> Tomi Ollila <tomi.ollila@iki.fi> writes:
>> +#if POSIX_2008_REALPATH
>>      filename = realpath (config->filename, NULL);
>> +#else
>> +    /* compatibility with minor effort, not elegance, is the ruling factor
>> +       in these (two) else branches... */
>> +    char resolved_path[PATH_MAX];
>> +    filename = realpath (config->filename, resolved_path);
>> +#endif


>
> I worry a bit about making the mainline code messier and harder to maintain, in order to
> accomodate an unknown number of targets without POSIX2008 realpath. Do
> we know how widespread this problem is? Is it just NetBSD?
>
> I looked at borrowing realpath from gnulib; it looks like it would be a
> bit of work as the least complicated version includes 3 other include
> files. But then the mainline code could be blisfully ignorant of the
> whole dispute.

We could also create

char * realpath2008 (const char * path, char * resolved_path)
{
        if (resolved_path == NULL) {
		resolved_path = malloc (MAX_PATH);
                if (resolved_path == NULL)
			return NULL;
        }
        return realpath (path, resolved_path);
}
        
And, in the case where NULL argument is accepted, 

#define realpath2008(path, resolved_path) realpath(path, resolved_path) 

(or an inline function to do the same)

In this case one is not totally ignorant to the whole dispute -- but
on the other hand, developer should be savvy about the potential 
issues using realpath() function, and this might just ring the bell...

> d

Tomi