From: Tomi Ollila <tomi.ollila@iki.fi>
To: Michal Sojka <sojkam1@fel.cvut.cz>, notmuch@notmuchmail.org
Subject: Re: [PATCH 0/2] Improve message threading
Date: Sun, 10 Aug 2014 22:49:45 +0300 [thread overview]
Message-ID: <m2fvh4azvq.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <1401113157-32454-1-git-send-email-sojkam1@fel.cvut.cz>
On Mon, May 26 2014, Michal Sojka <sojkam1@fel.cvut.cz> wrote:
> Hi all,
>
> I noticed that in certain situations notmuch does not reconstruct
> thread structure correctly. The fix was quite trivial - see the
> patches.
>
> The patch fixes my problem, however, as I learnt from the thread
> around id:87oazwjq1e.fsf@yoom.home.cworth.org, there are more problems
> in this code. I think that my problem is orthogonal to what was
> discussed there.
>
> The patch does not break any existing text (except two in
> T460-emacs-tree.sh, which fail even with 0.18 on my system).
>
> Cheers,
> -Michal
This series looks good to me, and patch 2/2 fixes the borken test
introduced in patch 1/2 -- i.e. the fix is clear, test is somewhat
tedious to be parsed by a human ;D
Tomi
>
> Michal Sojka (2):
> Add test for incorrect threading of messages
> Make parsing of References and In-Reply-To header less error prone
>
> lib/database.cc | 15 ++++++---------
> test/T510-thread-replies.sh | 27 +++++++++++++++++++++++++++
> 2 files changed, 33 insertions(+), 9 deletions(-)
>
> --
> 2.0.0.rc2
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2014-08-10 19:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-26 14:05 [PATCH 0/2] Improve message threading Michal Sojka
2014-05-26 14:05 ` [PATCH 1/2] Add test for incorrect threading of messages Michal Sojka
2014-05-26 14:05 ` [PATCH 2/2] Make parsing of References and In-Reply-To header less error prone Michal Sojka
2014-07-13 14:54 ` David Bremner
2014-08-10 19:49 ` Tomi Ollila [this message]
2014-08-17 0:49 ` [PATCH 0/2] Improve message threading David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2fvh4azvq.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=notmuch@notmuchmail.org \
--cc=sojkam1@fel.cvut.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).