From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id YBjPDYIvI191WgAA0tVLHw (envelope-from ) for ; Thu, 30 Jul 2020 20:37:22 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id YKB9CYIvI1+7fQAAbx9fmQ (envelope-from ) for ; Thu, 30 Jul 2020 20:37:22 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (2048 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B27FA940224 for ; Thu, 30 Jul 2020 20:37:20 +0000 (UTC) Received: from [144.217.243.247] (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id D055D2806A; Thu, 30 Jul 2020 16:37:12 -0400 (EDT) Received: from lahtoruutu.iki.fi (unknown [IPv6:2a0b:5c81:1c1::37]) by mail.notmuchmail.org (Postfix) with ESMTPS id AFDF91F965 for ; Thu, 30 Jul 2020 16:37:10 -0400 (EDT) Received: from guru.guru-group.fi (unknown [IPv6:2a02:2380:1:9:5054:ff:feb7:a4bc]) (using TLSv1.2 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: too) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id 7B5C71B00594; Thu, 30 Jul 2020 23:36:59 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1596141419; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=i0IFVB4oNn8kdfP27NMzZJufS31jWmD9csUO/PsFGck=; b=tjyuJP+Ex5uyEFcEPC4k83RISFxWYN1TyN1+mGjD9Y6DvXzabRogblMTSDLSduIqthzllk wPHgvfdbPKzuDjPZWyBev2WZ/mErHa94UB66iSOa3Eg0xtC69FeNPTmKUGsUwbGsD8WUAn 9bPdbyQAedldrHvbqVt1HTUBHHcIGmoAUJsEFEMx4rRfRGVayGQly9EG16a4vsP0NtozuF UkkGkqHp52YIKABYg/IVwL7UABY1YmVr20cm1FRQNVafVX6d3sDMSpF4VBOtcwkLqKigAj rk6O4rrMYZPf3iD/+HfKk8oYDh9WkIsL7Nsgmnooo7V7SJ6xUHdw3TF+ESFE4A== From: Tomi Ollila To: Jonas Bernoulli , notmuch@notmuchmail.org Subject: Re: [PATCH 00/23] A create number of cosmetic changes In-Reply-To: <20200726165818.400-1-jonas@bernoul.li> References: <20200726165818.400-1-jonas@bernoul.li> User-Agent: Notmuch/0.30+12~g9f4381f (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1596141419; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=i0IFVB4oNn8kdfP27NMzZJufS31jWmD9csUO/PsFGck=; b=cHJVea8/29igPqcfd0jXrZbk1EEf5P50jeWHnIRCPT4mTp4gDEuhDwMryxMa40+9+tyUZ8 ljZVKmw2QIRAeX2EQDxVzszbKpZ00oDTPh4ktYiLBlWAHvockQIIIPjk0+ohGPO2MR4hHy 4Q0kz3fK43egwKaQ/i5m/yCRXey7evLLFOOZY/Jx+5nd/NuP+J1MR/e4D+dRRUCxaa9TXO EMIe/rH/e4Z1H3W33fliJt0Gz1X172spaav/86izHIWX78kR3HX710yEFlwirf3w2oazG1 gByOVilarH57vfr6ebUDhrR9klRWCVzdne4n0Js7dIPwWVUilrDMoUtG8UiC6g== ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1596141419; a=rsa-sha256; cv=none; b=Q2tEaL4GgiHmT3JAGTH7V5Z++mbGzLeBBF6TsYFw8TpAtFtOEpEbEkORDNGNPK1jhEhfUV 27VlPYZLnUcqUlOQOqrFYDl2+zsGfSLlw2uragiVq+nobDPJcvcFuL3/RgjNaIe1oGS4Uc qKJgy5KKZZg6bSnlHEDsZPjnYth2YH7gEkEtvYktc8MdTWTNTDNRtPFlNBt3f30er9Mje8 Cnx1S+eRYcj8oAOLcF/TFeOZ0RbiOsrpm6BDAJSymgKEv/ly8K/Oq3WpiilTEkPpL1zuy7 xPLC2DvUfELyRSBnJX25EUMX2RGWpbXeboGBtJZagKAnvF8+0ILxBsGxazBp+g== ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=too smtp.mailfrom=tomi.ollila@iki.fi Message-ID-Hash: K2BBB5JCTDSVJGU2T3MA5N3M65GOWMB3 X-Message-ID-Hash: K2BBB5JCTDSVJGU2T3MA5N3M65GOWMB3 X-MailFrom: tomi.ollila@iki.fi X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (body hash did not verify) header.d=iki.fi header.s=lahtoruutu header.b=tjyuJP+E; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Spam-Score: 3.53 X-TUID: o4yph80wM+kH On Sun, Jul 26 2020, Jonas Bernoulli wrote: > Hello, > > Please forgive me for this wall of unsolicited cleanup; I blame it > on a mild form of ocd. I made most of these changes a few months > ago when I was splitting the libraries into `outline-minor-mode' > compatible sections. To do so I had to have some understanding of the > code I was splitting up and that closer look led to me discovering > issues and once I had ran into a bunch of issue of the same kind it > made sense to systematically look for that kind across all elisp > files. > > Well, one thing led to another and here we are with 23 cleanup > commits, some of which are fairly big on their own. I just looked > at very change again; everything looks to be in order. > > I am intentionally leaving out that one commit that actually does > what I originally set out to do. In some cases I will need to gain > a deeper understanding before I can finish splitting libraries into > sections. Series looks good to me (as far as I can tell). That one comment indentation in id:20200726165818.400-4-jonas@bernoul.li is what popped up in my review (I did review only diff patch, and don't know how that actually look -- like in those spaces after do in my previous reply, those look good to me now) One thing that come into my minw while browsing through patches -- does changing if's to when's accumulate any bloat -- or does byte compiler optimize that "extra" 'progn out in (list 'if cond (cons 'progn body))). > > Cheers, > Jonas Tomi > > Jonas Bernoulli (23): > emacs: Shorten long lines > emacs: Remove excess empty lines > emacs: Fix indentation > emacs: Closing parenthesis go on the same line > emacs: Only set one variable per setq form > emacs: Use cl-incf where appropriate > emacs: Use 'and' instead of 'when' when the return value matters > emacs: Use 'unless' instead of 'when' and 'not' > emacs: Use 'when' instead of 'if' when there is no ELSE part > emacs: Use one or three lines for 'if' forms > emacs: Extend face to window edge again > emacs: Fix some function declarations > emacs: No longer define notmuch-hello-mode-map as a function > emacs: notmuch-poll: Let the user know we are polling > emacs: Use makefile-gmake-mode in Makefile*s > emacs: Improve doc-strings > emacs: Autoload notmuch-jump-search only once > emacs: Autoload notmuch-jump using an autoload cookie > emacs: Various cosmetic changes > emacs: Increase consistency of library headers > Fix typos > .dir-locals.el: Set variables for correct "shell" mode > test: Fix indentation > > .dir-locals.el | 2 +- > Makefile.global | 1 + > Makefile.local | 2 +- > NEWS | 2 +- > bindings/Makefile.local | 2 +- > bindings/python-cffi/notmuch2/__init__.py | 2 +- > bindings/python-cffi/notmuch2/_base.py | 6 +- > bindings/python-cffi/notmuch2/_database.py | 8 +- > bindings/python-cffi/notmuch2/_message.py | 4 +- > bindings/python-cffi/notmuch2/_tags.py | 8 +- > bindings/python-cffi/tests/conftest.py | 2 +- > bindings/python/notmuch/database.py | 12 +- > bindings/python/notmuch/query.py | 2 +- > compat/Makefile.local | 2 +- > completion/Makefile.local | 2 +- > doc/Makefile.local | 2 +- > emacs/Makefile.local | 2 +- > emacs/coolj.el | 24 +- > emacs/make-deps.el | 5 +- > emacs/notmuch-address.el | 186 ++++----- > emacs/notmuch-company.el | 53 ++- > emacs/notmuch-compat.el | 99 +++-- > emacs/notmuch-crypto.el | 49 ++- > emacs/notmuch-draft.el | 24 +- > emacs/notmuch-hello.el | 102 +++-- > emacs/notmuch-jump.el | 61 ++- > emacs/notmuch-lib.el | 204 +++++----- > emacs/notmuch-maildir-fcc.el | 122 +++--- > emacs/notmuch-message.el | 3 +- > emacs/notmuch-mua.el | 181 ++++----- > emacs/notmuch-parser.el | 16 +- > emacs/notmuch-print.el | 2 +- > emacs/notmuch-query.el | 29 +- > emacs/notmuch-show.el | 439 ++++++++++----------- > emacs/notmuch-tag.el | 38 +- > emacs/notmuch-tree.el | 189 ++++----- > emacs/notmuch-wash.el | 109 +++-- > emacs/notmuch.el | 276 ++++++------- > emacs/rstdoc.el | 18 +- > lib/Makefile.local | 2 +- > lib/notmuch.h | 4 +- > parse-time-string/Makefile.local | 2 + > performance-test/Makefile.local | 2 +- > tag-util.c | 2 +- > tag-util.h | 2 +- > test/Makefile.local | 2 +- > test/T610-message-property.sh | 2 +- > test/T710-message-id.sh | 2 +- > test/emacs-address-cleaning.el | 2 +- > test/random-corpus.c | 2 +- > test/test-lib.el | 47 ++- > test/test-lib.sh | 36 +- > util/Makefile.local | 2 +- > 53 files changed, 1189 insertions(+), 1210 deletions(-) > > -- > 2.26.0 > _______________________________________________ > notmuch mailing list -- notmuch@notmuchmail.org > To unsubscribe send an email to notmuch-leave@notmuchmail.org