From: Tomi Ollila <tomi.ollila@iki.fi>
To: Jonas Bernoulli <jonas@bernoul.li>, notmuch@notmuchmail.org
Subject: Re: [PATCH 00/23] A create number of cosmetic changes
Date: Thu, 30 Jul 2020 23:36:58 +0300 [thread overview]
Message-ID: <m2ft98u4d1.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <20200726165818.400-1-jonas@bernoul.li>
On Sun, Jul 26 2020, Jonas Bernoulli wrote:
> Hello,
>
> Please forgive me for this wall of unsolicited cleanup; I blame it
> on a mild form of ocd. I made most of these changes a few months
> ago when I was splitting the libraries into `outline-minor-mode'
> compatible sections. To do so I had to have some understanding of the
> code I was splitting up and that closer look led to me discovering
> issues and once I had ran into a bunch of issue of the same kind it
> made sense to systematically look for that kind across all elisp
> files.
>
> Well, one thing led to another and here we are with 23 cleanup
> commits, some of which are fairly big on their own. I just looked
> at very change again; everything looks to be in order.
>
> I am intentionally leaving out that one commit that actually does
> what I originally set out to do. In some cases I will need to gain
> a deeper understanding before I can finish splitting libraries into
> sections.
Series looks good to me (as far as I can tell). That one comment
indentation in id:20200726165818.400-4-jonas@bernoul.li is what popped up
in my review (I did review only diff patch, and don't know how that
actually look -- like in those spaces after do in my previous reply, those
look good to me now)
One thing that come into my minw while browsing through patches -- does
changing if's to when's accumulate any bloat -- or does byte compiler
optimize that "extra" 'progn out in (list 'if cond (cons 'progn body))).
>
> Cheers,
> Jonas
Tomi
>
> Jonas Bernoulli (23):
> emacs: Shorten long lines
> emacs: Remove excess empty lines
> emacs: Fix indentation
> emacs: Closing parenthesis go on the same line
> emacs: Only set one variable per setq form
> emacs: Use cl-incf where appropriate
> emacs: Use 'and' instead of 'when' when the return value matters
> emacs: Use 'unless' instead of 'when' and 'not'
> emacs: Use 'when' instead of 'if' when there is no ELSE part
> emacs: Use one or three lines for 'if' forms
> emacs: Extend face to window edge again
> emacs: Fix some function declarations
> emacs: No longer define notmuch-hello-mode-map as a function
> emacs: notmuch-poll: Let the user know we are polling
> emacs: Use makefile-gmake-mode in Makefile*s
> emacs: Improve doc-strings
> emacs: Autoload notmuch-jump-search only once
> emacs: Autoload notmuch-jump using an autoload cookie
> emacs: Various cosmetic changes
> emacs: Increase consistency of library headers
> Fix typos
> .dir-locals.el: Set variables for correct "shell" mode
> test: Fix indentation
>
> .dir-locals.el | 2 +-
> Makefile.global | 1 +
> Makefile.local | 2 +-
> NEWS | 2 +-
> bindings/Makefile.local | 2 +-
> bindings/python-cffi/notmuch2/__init__.py | 2 +-
> bindings/python-cffi/notmuch2/_base.py | 6 +-
> bindings/python-cffi/notmuch2/_database.py | 8 +-
> bindings/python-cffi/notmuch2/_message.py | 4 +-
> bindings/python-cffi/notmuch2/_tags.py | 8 +-
> bindings/python-cffi/tests/conftest.py | 2 +-
> bindings/python/notmuch/database.py | 12 +-
> bindings/python/notmuch/query.py | 2 +-
> compat/Makefile.local | 2 +-
> completion/Makefile.local | 2 +-
> doc/Makefile.local | 2 +-
> emacs/Makefile.local | 2 +-
> emacs/coolj.el | 24 +-
> emacs/make-deps.el | 5 +-
> emacs/notmuch-address.el | 186 ++++-----
> emacs/notmuch-company.el | 53 ++-
> emacs/notmuch-compat.el | 99 +++--
> emacs/notmuch-crypto.el | 49 ++-
> emacs/notmuch-draft.el | 24 +-
> emacs/notmuch-hello.el | 102 +++--
> emacs/notmuch-jump.el | 61 ++-
> emacs/notmuch-lib.el | 204 +++++-----
> emacs/notmuch-maildir-fcc.el | 122 +++---
> emacs/notmuch-message.el | 3 +-
> emacs/notmuch-mua.el | 181 ++++-----
> emacs/notmuch-parser.el | 16 +-
> emacs/notmuch-print.el | 2 +-
> emacs/notmuch-query.el | 29 +-
> emacs/notmuch-show.el | 439 ++++++++++-----------
> emacs/notmuch-tag.el | 38 +-
> emacs/notmuch-tree.el | 189 ++++-----
> emacs/notmuch-wash.el | 109 +++--
> emacs/notmuch.el | 276 ++++++-------
> emacs/rstdoc.el | 18 +-
> lib/Makefile.local | 2 +-
> lib/notmuch.h | 4 +-
> parse-time-string/Makefile.local | 2 +
> performance-test/Makefile.local | 2 +-
> tag-util.c | 2 +-
> tag-util.h | 2 +-
> test/Makefile.local | 2 +-
> test/T610-message-property.sh | 2 +-
> test/T710-message-id.sh | 2 +-
> test/emacs-address-cleaning.el | 2 +-
> test/random-corpus.c | 2 +-
> test/test-lib.el | 47 ++-
> test/test-lib.sh | 36 +-
> util/Makefile.local | 2 +-
> 53 files changed, 1189 insertions(+), 1210 deletions(-)
>
> --
> 2.26.0
> _______________________________________________
> notmuch mailing list -- notmuch@notmuchmail.org
> To unsubscribe send an email to notmuch-leave@notmuchmail.org
next prev parent reply other threads:[~2020-07-30 20:37 UTC|newest]
Thread overview: 108+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-26 16:57 [PATCH 00/23] A create number of cosmetic changes Jonas Bernoulli
2020-07-26 16:57 ` [PATCH 01/23] emacs: Shorten long lines Jonas Bernoulli
2020-07-27 17:52 ` Tomi Ollila
2020-07-27 20:13 ` Jonas Bernoulli
2020-07-26 16:57 ` [PATCH 02/23] emacs: Remove excess empty lines Jonas Bernoulli
2020-07-27 18:00 ` Tomi Ollila
2020-07-27 20:25 ` Jonas Bernoulli
2020-07-26 16:57 ` [PATCH 03/23] emacs: Fix indentation Jonas Bernoulli
2020-07-30 20:07 ` Tomi Ollila
2020-08-01 20:37 ` Jonas Bernoulli
2020-07-26 16:57 ` [PATCH 04/23] emacs: Closing parenthesis go on the same line Jonas Bernoulli
2020-07-26 16:58 ` [PATCH 05/23] emacs: Only set one variable per setq form Jonas Bernoulli
2020-07-26 16:58 ` [PATCH 06/23] emacs: Use cl-incf where appropriate Jonas Bernoulli
2020-07-26 16:58 ` [PATCH 07/23] emacs: Use 'and' instead of 'when' when the return value matters Jonas Bernoulli
2020-07-26 21:27 ` Sean Whitton
2020-07-26 22:02 ` Jonas Bernoulli
2020-07-27 16:43 ` Sean Whitton
2020-07-27 20:32 ` Jonas Bernoulli
2020-07-26 16:58 ` [PATCH 08/23] emacs: Use 'unless' instead of 'when' and 'not' Jonas Bernoulli
2020-07-26 16:58 ` [PATCH 09/23] emacs: Use 'when' instead of 'if' when there is no ELSE part Jonas Bernoulli
2020-07-26 16:58 ` [PATCH 10/23] emacs: Use one or three lines for 'if' forms Jonas Bernoulli
2020-07-26 16:58 ` [PATCH 11/23] emacs: Extend face to window edge again Jonas Bernoulli
2020-07-26 16:58 ` [PATCH 12/23] emacs: Fix some function declarations Jonas Bernoulli
2020-07-26 16:58 ` [PATCH 13/23] emacs: No longer define notmuch-hello-mode-map as a function Jonas Bernoulli
2020-07-26 16:58 ` [PATCH 14/23] emacs: notmuch-poll: Let the user know we are polling Jonas Bernoulli
2020-07-26 16:58 ` [PATCH 15/23] emacs: Use makefile-gmake-mode in Makefile*s Jonas Bernoulli
2020-07-26 16:58 ` [PATCH 16/23] emacs: Improve doc-strings Jonas Bernoulli
2020-07-26 16:58 ` [PATCH 17/23] emacs: Autoload notmuch-jump-search only once Jonas Bernoulli
2020-07-26 16:58 ` [PATCH 18/23] emacs: Autoload notmuch-jump using an autoload cookie Jonas Bernoulli
2020-07-26 16:58 ` [PATCH 19/23] emacs: Various cosmetic changes Jonas Bernoulli
2020-07-26 16:58 ` [PATCH 20/23] emacs: Increase consistency of library headers Jonas Bernoulli
2020-07-26 16:58 ` [PATCH 21/23] Fix typos Jonas Bernoulli
2020-07-26 16:58 ` [PATCH 22/23] .dir-locals.el: Set variables for correct "shell" mode Jonas Bernoulli
2020-07-26 16:58 ` [PATCH 23/23] test: Fix indentation Jonas Bernoulli
2020-07-30 20:36 ` Tomi Ollila [this message]
2020-08-01 20:48 ` [PATCH 00/23] A great number of cosmetic changes Jonas Bernoulli
2020-08-03 17:32 ` David Bremner
2020-08-06 7:18 ` [PATCH v2 " Jonas Bernoulli
2020-08-06 7:18 ` [PATCH v2 01/23] emacs: Shorten long lines Jonas Bernoulli
2020-08-06 7:18 ` [PATCH v2 02/23] emacs: Remove excess empty lines Jonas Bernoulli
2020-08-06 7:18 ` [PATCH v2 03/23] emacs: Fix indentation Jonas Bernoulli
2020-08-06 7:18 ` [PATCH v2 04/23] emacs: Closing parenthesis go on the same line Jonas Bernoulli
2020-08-06 7:18 ` [PATCH v2 05/23] emacs: Only set one variable per setq form Jonas Bernoulli
2020-08-06 7:18 ` [PATCH v2 06/23] emacs: Use cl-incf where appropriate Jonas Bernoulli
2020-08-06 11:37 ` David Bremner
2020-08-06 13:37 ` Jonas Bernoulli
2020-08-07 17:03 ` Tomi Ollila
2020-08-07 17:22 ` David Bremner
2020-08-06 7:18 ` [PATCH v2 07/23] emacs: Use 'and' instead of 'when' when the return value matters Jonas Bernoulli
2020-08-06 7:18 ` [PATCH v2 08/23] emacs: Use 'unless' instead of 'when' and 'not' Jonas Bernoulli
2020-08-06 7:18 ` [PATCH v2 09/23] emacs: Use 'when' instead of 'if' when there is no ELSE part Jonas Bernoulli
2020-08-06 7:18 ` [PATCH v2 10/23] emacs: Use one or three lines for 'if' forms Jonas Bernoulli
2020-08-06 7:18 ` [PATCH v2 11/23] emacs: Extend face to window edge again Jonas Bernoulli
2020-08-06 7:18 ` [PATCH v2 12/23] emacs: Fix some function declarations Jonas Bernoulli
2020-08-06 7:19 ` [PATCH v2 13/23] emacs: No longer define notmuch-hello-mode-map as a function Jonas Bernoulli
2020-08-06 7:19 ` [PATCH v2 14/23] emacs: notmuch-poll: Let the user know we are polling Jonas Bernoulli
2020-08-06 7:19 ` [PATCH v2 15/23] emacs: Use makefile-gmake-mode in Makefile*s Jonas Bernoulli
2020-08-06 7:19 ` [PATCH v2 16/23] emacs: Improve doc-strings Jonas Bernoulli
2020-08-06 7:19 ` [PATCH v2 17/23] emacs: Autoload notmuch-jump-search only once Jonas Bernoulli
2020-08-06 7:19 ` [PATCH v2 18/23] emacs: Autoload notmuch-jump using an autoload cookie Jonas Bernoulli
2020-08-06 7:19 ` [PATCH v2 19/23] emacs: Various cosmetic changes Jonas Bernoulli
2020-08-06 7:19 ` [PATCH v2 20/23] emacs: Increase consistency of library headers Jonas Bernoulli
2020-08-06 7:19 ` [PATCH v2 21/23] Fix typos Jonas Bernoulli
2020-08-06 7:19 ` [PATCH v2 22/23] .dir-locals.el: Set variables for correct "shell" mode Jonas Bernoulli
2020-08-06 7:19 ` [PATCH v2 23/23] test: Fix indentation Jonas Bernoulli
2020-08-08 11:49 ` [PATCH v3 00/34] A great number of cosmetic changes Jonas Bernoulli
2020-08-08 11:49 ` [PATCH v3 01/34] emacs: Shorten long lines Jonas Bernoulli
2020-08-08 11:49 ` [PATCH v3 02/34] emacs: Remove excess empty lines Jonas Bernoulli
2020-08-08 11:49 ` [PATCH v3 03/34] emacs: Fix indentation Jonas Bernoulli
2020-08-08 11:49 ` [PATCH v3 04/34] emacs: Closing parenthesis go on the same line Jonas Bernoulli
2020-08-08 11:49 ` [PATCH v3 05/34] emacs: Only set one variable per setq form Jonas Bernoulli
2020-08-08 11:49 ` [PATCH v3 06/34] emacs: Use 'and' instead of 'when' when the return value matters Jonas Bernoulli
2020-08-08 11:49 ` [PATCH v3 07/34] emacs: Use 'unless' instead of 'when' and 'not' Jonas Bernoulli
2020-08-08 11:49 ` [PATCH v3 08/34] emacs: Use 'when' instead of 'if' when there is no ELSE part Jonas Bernoulli
2020-08-08 11:49 ` [PATCH v3 09/34] emacs: Use one or three lines for 'if' forms Jonas Bernoulli
2020-08-08 11:49 ` [PATCH v3 10/34] emacs: Extend face to window edge again Jonas Bernoulli
2020-08-08 11:49 ` [PATCH v3 11/34] emacs: Fix some function declarations Jonas Bernoulli
2020-08-08 11:49 ` [PATCH v3 12/34] emacs: No longer define notmuch-hello-mode-map as a function Jonas Bernoulli
2020-08-08 11:49 ` [PATCH v3 13/34] emacs: notmuch-poll: Let the user know we are polling Jonas Bernoulli
2020-08-08 11:49 ` [PATCH v3 14/34] emacs: Use makefile-gmake-mode in Makefile*s Jonas Bernoulli
2020-08-08 11:49 ` [PATCH v3 15/34] emacs: Improve doc-strings Jonas Bernoulli
2020-08-08 11:49 ` [PATCH v3 16/34] emacs: Autoload notmuch-jump-search only once Jonas Bernoulli
2020-08-08 11:49 ` [PATCH v3 17/34] emacs: Autoload notmuch-jump using an autoload cookie Jonas Bernoulli
2020-08-08 11:49 ` [PATCH v3 18/34] emacs: Various cosmetic changes Jonas Bernoulli
2020-08-08 11:49 ` [PATCH v3 19/34] emacs: Increase consistency of library headers Jonas Bernoulli
2020-08-08 11:49 ` [PATCH v3 20/34] Fix typos Jonas Bernoulli
2020-08-08 11:49 ` [PATCH v3 21/34] .dir-locals.el: Set variables for correct "shell" mode Jonas Bernoulli
2020-08-08 11:49 ` [PATCH v3 22/34] test: Fix indentation Jonas Bernoulli
2020-08-08 11:49 ` [PATCH v3 23/34] .gitignore: Sort using sort-lines Jonas Bernoulli
2020-08-08 11:49 ` [PATCH v3 24/34] emacs: Provide 'rstdoc' feature at end of file Jonas Bernoulli
2020-08-08 11:50 ` [PATCH v3 25/34] emacs: Add end-of-file line to libraries that lack it Jonas Bernoulli
2020-08-08 11:50 ` [PATCH v3 26/34] NEWS: Add stub for 0.31 Jonas Bernoulli
2020-08-08 11:50 ` [PATCH v3 27/34] NEWS: At least Emacs 25.1 is required now Jonas Bernoulli
2020-08-08 11:50 ` [PATCH v3 28/34] emacs: Use cl-incf where appropriate Jonas Bernoulli
2020-08-08 11:50 ` [PATCH v3 29/34] emacs: Remove notmuch-setq-local Jonas Bernoulli
2020-08-08 11:50 ` [PATCH v3 30/34] emacs: Remove notmuch-read-char-choice Jonas Bernoulli
2020-08-08 11:50 ` [PATCH v3 31/34] emacs: Drop old advices that were only need for Emacs 23 Jonas Bernoulli
2020-08-08 11:50 ` [PATCH v3 32/34] emacs: Do not abuse advice to monkey patch while testing Jonas Bernoulli
2020-08-08 11:50 ` [PATCH v3 33/34] emacs: Use new advice mechanism do advice mm-shr Jonas Bernoulli
2020-08-08 11:50 ` [PATCH v3 34/34] try-emacs-mua: Trim `require' advice for Emacs 25 Jonas Bernoulli
2020-08-09 7:15 ` [PATCH v3 00/34] A great number of cosmetic changes Tomi Ollila
2020-08-09 7:48 ` Jonas Bernoulli
2020-08-09 12:09 ` David Bremner
2020-08-09 12:41 ` Đoàn Trần Công Danh
2020-08-09 13:21 ` Jonas Bernoulli
2020-08-09 13:32 ` Jonas Bernoulli
2020-08-09 14:49 ` Tomi Ollila
2020-08-10 1:25 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2ft98u4d1.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=jonas@bernoul.li \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).