unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
* [PATCH] emacs: Refine scope of notmuch-jump-key face
@ 2021-07-17  8:30 Protesilaos Stavrou
  2021-08-05 12:10 ` David Bremner
  0 siblings, 1 reply; 3+ messages in thread
From: Protesilaos Stavrou @ 2021-07-17  8:30 UTC (permalink / raw)
  To: notmuch

The intent of the 'notmuch-jump-key' face is to allow users/themes to
differentiate the text of the minibuffer prompt from the keys that are
associated with jump actions.  Commit 5cc106b0 correctly introduced the
'notmuch-jump-key' face for keys, but mistakenly applied it to the
prompt as well.
---
 emacs/notmuch-jump.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/emacs/notmuch-jump.el b/emacs/notmuch-jump.el
index e228c8a2..5ec8eb9c 100644
--- a/emacs/notmuch-jump.el
+++ b/emacs/notmuch-jump.el
@@ -93,7 +93,7 @@ (defun notmuch-jump (action-map prompt)
 	    (buffer-string)))
 	 (full-prompt
 	  (concat table "\n\n"
-		  (propertize prompt 'face 'notmuch-jump-key)))
+		  (propertize prompt 'face 'minibuffer-prompt)))
 	 ;; By default, the minibuffer applies the minibuffer face to
 	 ;; the entire prompt.  However, we want to clearly
 	 ;; distinguish bindings (which we put in the prompt face
-- 
2.32.0



-- 
Protesilaos Stavrou
https://protesilaos.com

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] emacs: Refine scope of notmuch-jump-key face
  2021-07-17  8:30 [PATCH] emacs: Refine scope of notmuch-jump-key face Protesilaos Stavrou
@ 2021-08-05 12:10 ` David Bremner
  2021-08-09 20:02   ` Tomi Ollila
  0 siblings, 1 reply; 3+ messages in thread
From: David Bremner @ 2021-08-05 12:10 UTC (permalink / raw)
  To: Protesilaos Stavrou, notmuch

Protesilaos Stavrou <info@protesilaos.com> writes:

> The intent of the 'notmuch-jump-key' face is to allow users/themes to
> differentiate the text of the minibuffer prompt from the keys that are
> associated with jump actions.  Commit 5cc106b0 correctly introduced the
> 'notmuch-jump-key' face for keys, but mistakenly applied it to the
> prompt as well.

applied to master.

Shout out to Tomi for the review.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] emacs: Refine scope of notmuch-jump-key face
  2021-08-05 12:10 ` David Bremner
@ 2021-08-09 20:02   ` Tomi Ollila
  0 siblings, 0 replies; 3+ messages in thread
From: Tomi Ollila @ 2021-08-09 20:02 UTC (permalink / raw)
  To: David Bremner, Protesilaos Stavrou, notmuch

On Thu, Aug 05 2021, David Bremner wrote:

> Protesilaos Stavrou <info@protesilaos.com> writes:
>
>> The intent of the 'notmuch-jump-key' face is to allow users/themes to
>> differentiate the text of the minibuffer prompt from the keys that are
>> associated with jump actions.  Commit 5cc106b0 correctly introduced the
>> 'notmuch-jump-key' face for keys, but mistakenly applied it to the
>> prompt as well.
>
> applied to master.
>
> Shout out to Tomi for the review.

*hides*

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-08-09 20:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-17  8:30 [PATCH] emacs: Refine scope of notmuch-jump-key face Protesilaos Stavrou
2021-08-05 12:10 ` David Bremner
2021-08-09 20:02   ` Tomi Ollila

Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).