unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Cc: David Bremner <bremner@debian.org>
Subject: Re: [PATCH] STYLE: Initial draft of coding style document
Date: Mon, 30 Jan 2012 16:38:55 +0200	[thread overview]
Message-ID: <m2ehuhdzls.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <1327708018-1107-1-git-send-email-david@tethera.net>

On Fri, 27 Jan 2012 19:46:58 -0400, David Bremner <david@tethera.net> wrote:
> From: David Bremner <bremner@debian.org>

[ ... ]

> +
> +* Indent is 4 spaces with mixed tabs/spaces and a tab width of 8.
> +  Tabs should be only at the beginning of the line.

So, after initial indentation (with tabs) there should not be further
tabs? We'll be using the former instead of the latter in these 2 below?

/* excerpt from command-line-arguments.h -- indentation without tabs */

enum notmuch_opt_type {
    NOTMUCH_OPT_END = 0,
    NOTMUCH_OPT_BOOLEAN,        /* --verbose              */
    NOTMUCH_OPT_INT,            /* --frob=8               */
    NOTMUCH_OPT_KEYWORD,        /* --format=raw|json|text */
    NOTMUCH_OPT_STRING,         /* --file=/tmp/gnarf.txt  */
    NOTMUCH_OPT_POSITION        /* notmuch dump pos_arg   */
};

/* excerpt from command-line-arguments.h -- indentation with tabs */

enum notmuch_opt_type {
    NOTMUCH_OPT_END = 0,
    NOTMUCH_OPT_BOOLEAN,	/* --verbose              */
    NOTMUCH_OPT_INT,		/* --frob=8               */
    NOTMUCH_OPT_KEYWORD,	/* --format=raw|json|text */
    NOTMUCH_OPT_STRING,		/* --file=/tmp/gnarf.txt  */
    NOTMUCH_OPT_POSITION	/* notmuch dump pos_arg   */
};


[ ... ]


Tomi

  reply	other threads:[~2012-01-30 14:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-27 23:46 [PATCH] STYLE: Initial draft of coding style document David Bremner
2012-01-30 14:38 ` Tomi Ollila [this message]
2012-01-30 16:01   ` Jani Nikula
2012-02-04  0:50     ` David Bremner
2012-02-06  4:42       ` Austin Clements
2012-02-13  1:42         ` David Bremner
2012-02-19 20:54           ` Pieter Praet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2ehuhdzls.fsf@guru.guru-group.fi \
    --to=tomi.ollila@iki.fi \
    --cc=bremner@debian.org \
    --cc=david@tethera.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).