From: Tomi Ollila <tomi.ollila@iki.fi>
To: Michal Nazarewicz <mpn@google.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH] notmuch-show: add notmuch-show-mark-read-tags option
Date: Thu, 23 Aug 2012 09:38:26 +0300 [thread overview]
Message-ID: <m2ehmycdul.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <416b1203c83ea56c8e915a056465d9e202329f45.1345554683.git.mina86@mina86.com>
On Tue, Aug 21 2012, Michal Nazarewicz wrote:
> From: Michal Nazarewicz <mina86@mina86.com>
>
> The `notmuch-show-mark-read-tags' lists tags that are to be applied when
> message is read. By default, the only value is "-unread" which will remove
> the unread tag. Among other uses, this variable can be used to stop
> notmuch-show from modifying tags when message is shown (by setting the
> variable to an empty list).
> ---
LGTM.
Tomi
>
> I've sent this patch a while back but I think it got lost somehow so
> resending.
>
> emacs/notmuch-show.el | 12 ++++++++++--
> 1 files changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index 82b5399..c9fd867 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -183,6 +183,13 @@ provided with an MLA argument nor `completing-read' input."
> notmuch-show-stash-mlarchive-link-alist))
> :group 'notmuch-show)
>
> +(defcustom notmuch-show-mark-read-tags '("-unread")
> + "List of tags to apply when message is read, ie. shown in notmuch-show
> +buffer."
> + :type '(repeat string)
> + :group 'notmuch-show)
> +
> +
> (defmacro with-current-notmuch-show-message (&rest body)
> "Evaluate body with current buffer set to the text of current message"
> `(save-excursion
> @@ -1383,8 +1390,9 @@ current thread."
> (notmuch-show-get-prop :headers-visible))
>
> (defun notmuch-show-mark-read ()
> - "Mark the current message as read."
> - (notmuch-show-tag-message "-unread"))
> + "Apply `notmuch-show-mark-read-tags' to the message."
> + (when notmuch-show-mark-read-tags
> + (apply 'notmuch-show-tag-message notmuch-show-mark-read-tags)))
>
> ;; Functions for getting attributes of several messages in the current
> ;; thread.
> --
> 1.7.7.3
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2012-08-23 6:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-21 13:13 [PATCH] notmuch-show: add notmuch-show-mark-read-tags option Michal Nazarewicz
2012-08-23 6:38 ` Tomi Ollila [this message]
2012-08-29 22:11 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2ehmycdul.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=mpn@google.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).