From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>, Jed Brown <jed@59A2.org>,
Jani Nikula <jani@nikula.org>, Karl Fogel <kfogel@red-bean.com>,
Daniel Bergey <bergey@alum.mit.edu>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el.
Date: Tue, 09 Apr 2013 15:12:34 +0300 [thread overview]
Message-ID: <m2ehejykb1.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <87vc7vgbym.fsf@zancas.localnet>
On Tue, Apr 09 2013, David Bremner wrote:
> Tomi Ollila <tomi.ollila@iki.fi> writes:
>
>> On Tue, Apr 09 2013, Jed Brown wrote:
>>
>>> David Bremner <david@tethera.net> writes:
>>>
>>>> Squashed sounds good to me too. Sorry I'm too lazy/busy at the moment to
>>>> do it myself.
>>>
>>> I tested the attached and it's working as expected. Sent as an
>>> attachment to preserve author information.
>>
>> LGTM (this time tested, too). Also compared diffs by hand, change as announced.
>> comments in id:m26207wgyt.fsf@guru.guru-group.fi (amend!) apply.
>
> There seems to be a few warnings:
>
> In notmuch-bbdb/snarf-from:
> notmuch-address.el:116:26:Warning: reference to free variable
> `bbdb-get-addresses-headers'
>
> In notmuch-bbdb/snarf-to:
> notmuch-address.el:122:29:Warning: reference to free variable
> `bbdb-get-addresses-headers'
>
> In end of data:
> notmuch-address.el:143:1:Warning: the following functions are not known to be
> defined: bbdb-get-addresses, bbdb-update-records, notmuch-show-get-header
>
> Do we need a few defvars?
For the above set, something like:
(defvar bbdb-get-addresses-headers)
(declare-function notmuch-show-get-header "notmuch-show" (header &optional props))
(declare-function bbdb-get-addresses "bbdb-com"
(only-first-address
uninteresting-senders
get-header-content-function
&rest get-header-content-function-args))
(declare-function bbdb-update-records "bbdb-com" (addrs auto-create-p offer-to-create))
> d
Tomi
next prev parent reply other threads:[~2013-04-09 12:12 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-06 18:33 [PATCH] emacs: add missing paren to fix defun in notmuch-address.el Karl Fogel
2013-04-07 13:52 ` David Bremner
2013-04-07 21:50 ` Karl Fogel
2013-04-08 8:16 ` Tomi Ollila
2013-04-08 8:40 ` Jani Nikula
2013-04-08 10:50 ` David Bremner
2013-04-09 1:12 ` Jed Brown
2013-04-09 6:32 ` Tomi Ollila
2013-04-09 11:50 ` David Bremner
2013-04-09 12:12 ` Tomi Ollila [this message]
2014-07-04 0:38 ` Sebastian Lipp
2014-07-04 0:56 ` Karl Fogel
2014-07-04 9:25 ` Sebastian Lipp
2014-07-05 18:18 ` Karl Fogel
2014-07-06 20:41 ` Sebastian Lipp
2014-07-07 17:35 ` Karl Fogel
2014-07-06 20:37 ` Sebastian Lipp
2014-07-07 17:40 ` Karl Fogel
2014-07-08 8:56 ` Tomi Ollila
2014-07-08 17:59 ` Karl Fogel
2014-07-04 16:31 ` Tomi Ollila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2ehejykb1.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=bergey@alum.mit.edu \
--cc=david@tethera.net \
--cc=jani@nikula.org \
--cc=jed@59A2.org \
--cc=kfogel@red-bean.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).