From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>,
Mark Walters <markwalters1009@gmail.com>,
notmuch@notmuchmail.org
Subject: Re: [PATCH 1/1] emacs: fixed (declare-function ...) definitions
Date: Sat, 27 Apr 2013 12:39:17 +0300 [thread overview]
Message-ID: <m2ehdwz516.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <87mwt2ve95.fsf@zancas.localnet>
On Sat, Apr 13 2013, David Bremner <david@tethera.net> wrote:
> Mark Walters <markwalters1009@gmail.com> writes:
>
>> On Wed, 10 Apr 2013, Tomi Ollila <tomi.ollila@iki.fi> wrote:
>>> Some (declare-function ...) definitions were drifted away from the
>>> actual (defun ...)'s. To find the drifts and to verify changes
>>> the following command line was used:
>>>
>>> $ emacs --batch -L emacs --eval '(check-declare-directory "emacs")'
>>
>> This patch looks good to me +1.
>>
>> Is it worth making the above command into a test?
I attempted to do a test -- failed miserably with test_emacs ()
> Maybe a release check?
You want to delegate the work developers should do to yourself
(if not fixing the things, moan about those ;)
For the time being I drop needs-review tag.
> d
Tomi
next prev parent reply other threads:[~2013-04-27 9:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-10 21:42 [PATCH 1/1] emacs: fixed (declare-function ...) definitions Tomi Ollila
2013-04-13 6:55 ` Mark Walters
2013-04-13 11:52 ` David Bremner
2013-04-27 9:39 ` Tomi Ollila [this message]
2013-04-30 9:19 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2ehdwz516.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=david@tethera.net \
--cc=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).