From: Tomi Ollila <tomi.ollila@iki.fi>
To: Daniel Kahn Gillmor <dkg@fifthhorseman.net>,
Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH v2] cli/help: give a hint about notmuch-emacs-mua
Date: Mon, 04 Dec 2017 22:56:31 +0200 [thread overview]
Message-ID: <m2efoaw6tc.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <20171204184310.17125-1-dkg@fifthhorseman.net>
On Mon, Dec 04 2017, Daniel Kahn Gillmor wrote:
> "notmuch help" doesn't mention "notmuch-emacs-mua" even though we
> support it through the try_external_command() mechanism.
>
> In addition, "notmuch help emacs-mua" doesn't work, even though we
> ship the appropriate manpage.
>
> This changeset fixes both of these problems.
+1
Tomi
> ---
> configure | 1 +
> notmuch.c | 7 ++++++-
> 2 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index bd034f91..f1974520 100755
> --- a/configure
> +++ b/configure
> @@ -1185,6 +1185,7 @@ COMMON_CONFIGURE_CFLAGS = \\
> \$(GMIME_CFLAGS) \$(TALLOC_CFLAGS) \$(ZLIB_CFLAGS) \\
> -DHAVE_VALGRIND=\$(HAVE_VALGRIND) \$(VALGRIND_CFLAGS) \\
> -DHAVE_GETLINE=\$(HAVE_GETLINE) \\
> + -DWITH_EMACS=\$(WITH_EMACS) \\
> -DHAVE_CANONICALIZE_FILE_NAME=\$(HAVE_CANONICALIZE_FILE_NAME) \\
> -DHAVE_STRCASESTR=\$(HAVE_STRCASESTR) \\
> -DHAVE_STRSEP=\$(HAVE_STRSEP) \\
> diff --git a/notmuch.c b/notmuch.c
> index d5bf7902..2d193aa8 100644
> --- a/notmuch.c
> +++ b/notmuch.c
> @@ -172,6 +172,10 @@ static command_t commands[] = {
> "Re-index all messages matching the search terms." },
> { "config", notmuch_config_command, NOTMUCH_CONFIG_OPEN,
> "Get or set settings in the notmuch configuration file." },
> +#if WITH_EMACS
> + { "emacs-mua", NULL, 0,
> + "send mail with notmuch and emacs." },
> +#endif
> { "help", notmuch_help_command, NOTMUCH_CONFIG_CREATE, /* create but don't save config */
> "This message, or more detailed help for the named command." }
> };
> @@ -487,7 +491,8 @@ main (int argc, char *argv[])
> notmuch_process_shared_options (command_name);
>
> command = find_command (command_name);
> - if (!command) {
> + /* if command->function is NULL, try external command */
> + if (!command || !command->function) {
> /* This won't return if the external command is found. */
> if (try_external_command(argv + opt_index))
> fprintf (stderr, "Error: Unknown command '%s' (see \"notmuch help\")\n",
> --
> 2.15.0
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2017-12-04 20:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-26 21:27 [PATCH] cli/help: give a hint about notmuch-emacs-mua Daniel Kahn Gillmor
2017-11-30 5:55 ` Daniel Kahn Gillmor
2017-11-30 9:08 ` Tomi Ollila
2017-11-30 14:13 ` Daniel Kahn Gillmor
2017-12-03 13:26 ` Tomi Ollila
2017-12-04 15:44 ` Daniel Kahn Gillmor
2017-12-04 18:44 ` Daniel Kahn Gillmor
2017-12-04 18:43 ` [PATCH v2] " Daniel Kahn Gillmor
2017-12-04 20:56 ` Tomi Ollila [this message]
2017-12-07 12:31 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2efoaw6tc.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=dkg@fifthhorseman.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).