From: Tomi Ollila <tomi.ollila@iki.fi>
To: Daniel Kahn Gillmor <dkg@fifthhorseman.net>,
Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH 1/2 v2] test-lib: mark function variables as local
Date: Sat, 09 May 2020 10:09:36 +0300 [thread overview]
Message-ID: <m2eerteg9b.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <20200508232438.169867-1-dkg@fifthhorseman.net>
On Fri, May 08 2020, Daniel Kahn Gillmor wrote:
> Several functions in test/test-lib.sh used variable names that are
> also used outside of those functions (e.g. $output and $expected are
> used in many of the test scripts), but they are not expected to
> communicate via those variables.
>
> We mark those variables "local" within test-lib.sh so that they do not
> get clobbered when used outside test-lib.
>
> We also move the local variable declarations to beginning of each
> function, to avoid weird gotchas with local variable declarations as
> described in https://tldp.org/LDP/abs/html/localvar.html.
LGTM. I have to tolerate 'we' (passive) as I seem to use those myself, too
(although communicating a bit different thing...) =D
Tomi
> Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
> ---
> test/test-lib.sh | 31 ++++++++++++++++++++++---------
> 1 file changed, 22 insertions(+), 9 deletions(-)
>
> diff --git a/test/test-lib.sh b/test/test-lib.sh
> index 5c8eab7c..58972339 100644
> --- a/test/test-lib.sh
> +++ b/test/test-lib.sh
> @@ -109,7 +109,6 @@ unset ALTERNATE_EDITOR
>
> add_gnupg_home ()
> {
> - local output
> [ -e "${GNUPGHOME}/gpg.conf" ] && return
> _gnupg_exit () { gpgconf --kill all 2>/dev/null || true; }
> at_exit_function _gnupg_exit
> @@ -345,13 +344,14 @@ trap 'trap_signal' HUP INT TERM
> # to the message and encrypting/signing.
> emacs_deliver_message ()
> {
> - local subject="$1"
> - local body="$2"
> + local subject body smtp_dummy_pid smtp_dummy_port
> + subject="$1"
> + body="$2"
> shift 2
> # before we can send a message, we have to prepare the FCC maildir
> mkdir -p "$MAIL_DIR"/sent/{cur,new,tmp}
> # eval'ing smtp-dummy --background will set smtp_dummy_pid and -_port
> - local smtp_dummy_pid= smtp_dummy_port=
> + smtp_dummy_pid= smtp_dummy_port=
> eval `$TEST_DIRECTORY/smtp-dummy --background sent_message`
> test -n "$smtp_dummy_pid" || return 1
> test -n "$smtp_dummy_port" || return 1
> @@ -391,13 +391,14 @@ emacs_deliver_message ()
> # new" after message delivery
> emacs_fcc_message ()
> {
> - local nmn_args=''
> + local nmn_args subject body
> + nmn_args=''
> while [[ "$1" =~ ^-- ]]; do
> nmn_args="$nmn_args $1"
> shift
> done
> - local subject="$1"
> - local body="$2"
> + subject="$1"
> + body="$2"
> shift 2
> # before we can send a message, we have to prepare the FCC maildir
> mkdir -p "$MAIL_DIR"/sent/{cur,new,tmp}
> @@ -427,6 +428,7 @@ emacs_fcc_message ()
> # number of messages.
> add_email_corpus ()
> {
> + local corpus
> corpus=${1:-default}
>
> rm -rf ${MAIL_DIR}
> @@ -457,6 +459,7 @@ test_begin_subtest ()
> # name.
> test_expect_equal ()
> {
> + local output expected testname
> exec 1>&6 2>&7 # Restore stdout and stderr
> if [ -z "$inside_subtest" ]; then
> error "bug in the test script: test_expect_equal without test_begin_subtest"
> @@ -483,6 +486,7 @@ test_expect_equal ()
> # Like test_expect_equal, but takes two filenames.
> test_expect_equal_file ()
> {
> + local file1 file2 testname basename1 basename2
> exec 1>&6 2>&7 # Restore stdout and stderr
> if [ -z "$inside_subtest" ]; then
> error "bug in the test script: test_expect_equal_file without test_begin_subtest"
> @@ -512,10 +516,11 @@ test_expect_equal_file ()
> # canonicalized before diff'ing. If an argument cannot be parsed, it
> # is used unchanged so that there's something to diff against.
> test_expect_equal_json () {
> + local script output expected
> # The test suite forces LC_ALL=C, but this causes Python 3 to
> # decode stdin as ASCII. We need to read JSON in UTF-8, so
> # override Python's stdio encoding defaults.
> - local script='import json, sys; json.dump(json.load(sys.stdin), sys.stdout, sort_keys=True, indent=4)'
> + script='import json, sys; json.dump(json.load(sys.stdin), sys.stdout, sort_keys=True, indent=4)'
> output=$(echo "$1" | PYTHONIOENCODING=utf-8 $NOTMUCH_PYTHON -c "$script" \
> || echo "$1")
> expected=$(echo "$2" | PYTHONIOENCODING=utf-8 $NOTMUCH_PYTHON -c "$script" \
> @@ -540,6 +545,7 @@ test_sort_json () {
> # read the source of test/json_check_nodes.py (or the output when
> # invoking it without arguments) for an explanation of the syntax.
> test_json_nodes () {
> + local output
> exec 1>&6 2>&7 # Restore stdout and stderr
> if [ -z "$inside_subtest" ]; then
> error "bug in the test script: test_json_eval without test_begin_subtest"
> @@ -561,6 +567,7 @@ test_json_nodes () {
> }
>
> test_emacs_expect_t () {
> + local result
> test "$#" = 1 ||
> error "bug in the test script: not 1 parameter to test_emacs_expect_t"
> if [ -z "$inside_subtest" ]; then
> @@ -653,7 +660,8 @@ notmuch_json_show_sanitize ()
>
> notmuch_emacs_error_sanitize ()
> {
> - local command=$1
> + local command
> + command=$1
> shift
> for file in "$@"; do
> echo "=== $file ==="
> @@ -717,6 +725,7 @@ declare -A test_subtest_missing_external_prereq_
>
> # declare prerequisite for the given external binary
> test_declare_external_prereq () {
> + local binary
> binary="$1"
> test "$#" = 2 && name=$2 || name="$binary(1)"
>
> @@ -734,6 +743,7 @@ $binary () {
> # called indirectly (e.g. from emacs).
> # Returns success if dependency is available, failure otherwise.
> test_require_external_prereq () {
> + local binary
> binary="$1"
> if [[ ${test_missing_external_prereq_["${binary}"]} == t ]]; then
> # dependency is missing, call the replacement function to note it
> @@ -1075,6 +1085,7 @@ test_ruby() {
> }
>
> test_C () {
> + local exec_file test_file
> exec_file="test${test_count}"
> test_file="${exec_file}.c"
> cat > ${test_file}
> @@ -1086,6 +1097,7 @@ test_C () {
> }
>
> make_shim () {
> + local base_name test_file shim_file
> base_name="$1"
> test_file="${base_name}.c"
> shim_file="${base_name}.so"
> @@ -1094,6 +1106,7 @@ make_shim () {
> }
>
> notmuch_with_shim () {
> + local base_name shim_file
> base_name="$1"
> shift
> shim_file="${base_name}.so"
> --
> 2.26.2
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2020-05-09 7:09 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 20:13 Handle PKCS#7 S/MIME messages Daniel Kahn Gillmor
2020-04-30 20:13 ` [PATCH 1/9] lib: index PKCS7 SignedData parts Daniel Kahn Gillmor
2020-04-30 20:13 ` [PATCH 2/9] smime: Identify encrypted S/MIME parts during indexing Daniel Kahn Gillmor
2020-04-30 20:13 ` [PATCH 3/9] cli: include wrapped part of PKCS#7 SignedData in the MIME tree Daniel Kahn Gillmor
2020-04-30 20:13 ` [PATCH 4/9] cli/show: If a leaf part has children, show them instead of omitting Daniel Kahn Gillmor
2020-04-30 20:13 ` [PATCH 5/9] cli/reply: Ignore PKCS#7 wrapper parts when replying Daniel Kahn Gillmor
2020-04-30 20:13 ` [PATCH 6/9] crypto: Make _notmuch_crypto_decrypt take a GMimeObject Daniel Kahn Gillmor
2020-04-30 20:13 ` [PATCH 7/9] crypto: handle PKCS#7 envelopedData in _notmuch_crypto_decrypt Daniel Kahn Gillmor
2020-04-30 20:13 ` [PATCH 8/9] smime: Pass PKCS#7 envelopedData to node_decrypt_and_verify Daniel Kahn Gillmor
2020-04-30 20:13 ` [PATCH 9/9] smime: Index cleartext of envelopedData when requested Daniel Kahn Gillmor
2020-05-01 21:15 ` Handle PKCS#7 S/MIME messages Tomi Ollila
2020-05-04 19:16 ` Daniel Kahn Gillmor
2020-05-05 8:32 ` Tomi Ollila
2020-05-05 18:07 ` David Bremner
2020-05-06 23:54 ` [PATCH 1/2] test-lib: mark function variables as local Daniel Kahn Gillmor
2020-05-06 23:54 ` [PATCH 2/2] smime: tests of X.509 certificate validity are known-broken on GMime < 3.2.7 Daniel Kahn Gillmor
2020-05-07 20:54 ` Tomi Ollila
2020-05-12 22:20 ` [PATCH 2/2 v2] " Daniel Kahn Gillmor
2020-05-21 23:29 ` David Bremner
2020-05-22 0:41 ` Daniel Kahn Gillmor
2020-05-22 0:42 ` [PATCH 2/2 v3] " Daniel Kahn Gillmor
2020-05-23 11:56 ` David Bremner
2020-05-07 7:31 ` [PATCH 1/2] test-lib: mark function variables as local Tomi Ollila
2020-05-08 20:04 ` Daniel Kahn Gillmor
2020-05-08 23:24 ` [PATCH 1/2 v2] " Daniel Kahn Gillmor
2020-05-09 7:09 ` Tomi Ollila [this message]
2020-05-09 11:47 ` David Bremner
2020-05-10 18:03 ` Daniel Kahn Gillmor
2020-05-10 19:02 ` David Bremner
2020-05-12 22:14 ` Daniel Kahn Gillmor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2eerteg9b.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=dkg@fifthhorseman.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).