From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Cc: David Bremner <david@tethera.net>
Subject: Re: [PATCH 1/2] test: drop NOTMUCH_DEFAULT_XAPIAN_BACKEND from T360-symbol-test
Date: Fri, 31 Jul 2020 20:38:37 +0300 [thread overview]
Message-ID: <m2eeorzisi.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <20200730000130.989410-1-david@tethera.net>
On Wed, Jul 29 2020, David Bremner wrote:
> Inspired by the suggestion of
>
> id:20200727154108.16269-3-congdanhqx@gmail.com
>
> to drop the configuration test for the default backend. This version
> is hopefully robust against backend changes.
> ---
> test/T360-symbol-hiding.sh | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/test/T360-symbol-hiding.sh b/test/T360-symbol-hiding.sh
> index 43921cb4..4f1eb605 100755
> --- a/test/T360-symbol-hiding.sh
> +++ b/test/T360-symbol-hiding.sh
> @@ -14,11 +14,11 @@ test_description='exception symbol hiding'
> test_begin_subtest 'running test' run_test
> mkdir -p ${PWD}/fakedb/.notmuch
> $TEST_DIRECTORY/symbol-test ${PWD}/fakedb ${PWD}/nonexistent 2>&1 \
> - | notmuch_dir_sanitize | sed -e "s,\`,\',g" -e "s,${NOTMUCH_DEFAULT_XAPIAN_BACKEND},backend,g" > OUTPUT
> + | notmuch_dir_sanitize | sed -e "s,\`,\',g" -e "s,No [^ \t]* database,No XXXXXX database,g" > OUTPUT
Restore lost tab in the beginning of line, use [^[:space:]] for portability
Tomi
>
> cat <<EOF > EXPECTED
> A Xapian exception occurred opening database: Couldn't stat 'CWD/fakedb/.notmuch/xapian'
> -caught No backend database found at path 'CWD/nonexistent'
> +caught No XXXXXX database found at path 'CWD/nonexistent'
> EOF
> test_expect_equal_file EXPECTED OUTPUT
>
> --
> 2.27.0
> _______________________________________________
> notmuch mailing list -- notmuch@notmuchmail.org
> To unsubscribe send an email to notmuch-leave@notmuchmail.org
next prev parent reply other threads:[~2020-07-31 17:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 0:01 [PATCH 1/2] test: drop NOTMUCH_DEFAULT_XAPIAN_BACKEND from T360-symbol-test David Bremner
2020-07-30 0:01 ` [PATCH 2/2] test: drop use of db_ending David Bremner
2020-07-31 17:38 ` Tomi Ollila [this message]
2020-08-01 23:35 ` [PATCH 1/2] test: drop NOTMUCH_DEFAULT_XAPIAN_BACKEND from T360-symbol-test David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2eeorzisi.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).