From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id mKkrFYbv/l+BdAAA0tVLHw (envelope-from ) for ; Wed, 13 Jan 2021 13:03:02 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id SDANEYbv/l+JWgAAB5/wlQ (envelope-from ) for ; Wed, 13 Jan 2021 13:03:02 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (2048 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7FEF39403E8 for ; Wed, 13 Jan 2021 13:03:01 +0000 (UTC) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 38B2129ED5; Wed, 13 Jan 2021 08:02:54 -0500 (EST) Received: from lahtoruutu.iki.fi (lahtoruutu.iki.fi [185.185.170.37]) by mail.notmuchmail.org (Postfix) with ESMTPS id A233029E26 for ; Wed, 13 Jan 2021 08:02:52 -0500 (EST) Received: from guru.guru-group.fi (unknown [IPv6:2a02:2380:1:9:5054:ff:feb7:a4bc]) (using TLSv1.2 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: too) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id 0C5251B00258; Wed, 13 Jan 2021 15:02:49 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1610542969; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aOHdahBqvvTS/Mz1a6fo7OOCmRCZ+mtN1kh0OBkgnh8=; b=McxF4wJduiweiVI/zmE0erxK51lh25s9kdsEyyh48EwLaZc+XJgRHpPvrI4O4a10TWkYKm Mbz+Ptgh9lWBZzuwkw6/OsyyU6U9AaVFSf147HXsZzXQU8PTahX5/flCU2bwn20CxM74CV vNpWuuhZWtCUxqJJQEO1qe91WydqjrP7FYVUlKzCduwHH6MXVVQf+WdoZpuyRl6uDLXmMd PnFDPeTrqzNpfDJhko/SJAD9BOItgbPXzDjXbZbS6dHGaJ9q/wuS5Qvn/rfvau4KYO6SvE vzvl1PK6LQJ5w5YIZNZYxwcVeiI72+k66nNlsIgH3rW3f+dmBmxKysTdryppqg== From: Tomi Ollila To: David Bremner , Jonas Bernoulli , notmuch@notmuchmail.org Subject: Re: [PATCH v2 00/36] [emacs] Add outline headings and switch to lexical scope In-Reply-To: <87r1mp595c.fsf@tethera.net> References: <20201214162401.19569-1-jonas@bernoul.li> <20210110140112.25930-1-jonas@bernoul.li> <87r1mp595c.fsf@tethera.net> User-Agent: Notmuch/0.31.3+83~gfe438d5 (https://notmuchmail.org) Emacs/27.1 X-Face: HhBM'cA~ MIME-Version: 1.0 ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1610542969; a=rsa-sha256; cv=none; b=QpLTHtqLO2SHvgoQnfA0r3qpJMTwFkJiaRSsq29SJ91rm2drO8zrXlm3gKg70xxyFLjV8g N4hxySf37NJ4ANwRVVgM1smOrpaC0fYckMHuwjdoe6kkw0IldVgwLtl2bzo0m9xbJGEFd1 qi45YPJkwMwaaQ/YeQkXzhDYLlS0oRoGU4Z5t9cVKWqr9Wjk6ZUaeZHsDAgTOnPWmY10+1 XXv8q1l/wa9v4ZUxGwhuuKkLHVwE1YzDTWpyg25gFvwsvRaO4oLmz/l5cOS0RC3txT0NZa iXhNFyJwAkdEhi5fgAEw59sZaRpgXgyDp6b6eUAk73/xhEBtqXyaAaIBWF+DNg== ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=too smtp.mailfrom=tomi.ollila@iki.fi ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1610542969; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aOHdahBqvvTS/Mz1a6fo7OOCmRCZ+mtN1kh0OBkgnh8=; b=ueEHc4umz47Ru5UvehnsY5LCtxFud4I3SieXvaTc6qy7m4iLk4xR3xAONS78OZP3Xtzrgx xRTWqAjk0kd40sKP3qHyJWWhdVfJ7E4oEZSFt5kM3krpNvcgAGvOAF1s0eS0OjokmOoxGB 3OmjBvamyB6yvgy5UhHOe94f0ihi37eOant9fqkRd5DM2YoMB+OemY5/4Fks613mKJi9Ds tTTX8gQZGWV7RXk5oGkH+AsspBumeR2xJvPHwYT+IxOKBg7acEeh5AEcRz/EDeC+cq4wFK 8oc+OYQP6KaMyADSCqViytI68qy5wILTpRC2WYTJwDuggcUD0xS6ncgjcuuzMg== Message-ID-Hash: PTPCZIBAZXA64A3CJWIQ4QOVAJX34BXL X-Message-ID-Hash: PTPCZIBAZXA64A3CJWIQ4QOVAJX34BXL X-MailFrom: tomi.ollila@iki.fi X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: 0.93 Authentication-Results: aspmx1.migadu.com; dkim=fail (body hash did not verify) header.d=iki.fi header.s=lahtoruutu header.b=McxF4wJd; arc=reject (signature check failed: fail, {[1] = sig:iki.fi:reject}); dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 7FEF39403E8 X-Spam-Score: 0.93 X-Migadu-Scanner: scn1.migadu.com X-TUID: Xcvkgju6SlDO On Wed, Jan 13 2021, David Bremner wrote: > Jonas Bernoulli writes: > >> This fixes a minor whitespace bug that Tomi notices in (1). >> >> This also adds for commits, two of them in response to a concern >> raised by Tomi, who didn't "see enough point for requiring subr-x >> just [for string-empty-p]", which I agree with: >> >> 2) Changes how `cl-lib' and `pcase' are required. I did that first >> because I want to do it the same way as for `subr-x'. >> >> 3) Require `subr-x', so that we can use it without having to worry >> whether we have now reached the threshold where it becomes >> justified to require an additional library. > > I pushed applied the first 22 patches to master. > > "[PATCH v2 23/36] emacs: various cosmetic improvements" leads to some > test failures. FWIW, I'm using Emacs 27.1 on Debian testing. I got the same. After some trial and error w/ "educated guesses", reverting this change in notmuch-maildir-fcc.el (git diff from my tree after revert), test passed. in emacs/notmuch-maildir-fcc.el @@ -107,13 +107,16 @@ (defun notmuch-fcc-header-setup () ;; Old style - no longer works. (error "Invalid `notmuch-fcc-dirs' setting (old style)")) ((listp notmuch-fcc-dirs) - (or (seq-some (let ((from (message-field-value "From"))) - (pcase-lambda (`(,regexp ,folder)) - (and (string-match-p regexp from) - folder))) - notmuch-fcc-dirs) - (progn (message "No Fcc header added.") - nil))) + (let* ((from (message-field-value "From")) + (match + (catch 'first-match + (dolist (re-folder notmuch-fcc-dirs) + (when (string-match-p (car re-folder) from) + (throw 'first-match re-folder)))))) + (if match + (cdr match) + (message "No Fcc header added.") + nil))) > > T310-emacs: Testing emacs interface > FAIL notmuch-fcc-dirs set to a list (with match) > --- T310-emacs.28.EXPECTED 2021-01-13 12:00:57.901428602 +0000 > +++ T310-emacs.28.OUTPUT 2021-01-13 12:00:57.905428701 +0000 > @@ -1,5 +0,0 @@ > -From: Notmuch Test Suite > -To: > -Subject: > -Fcc: /home/bremner/software/upstream/notmuch/test/tmp.T310-emacs/mail/sent-list-match > ---text follows this line-- > *ERROR*: Wrong type argument: listp, "sent-list-match" > FAIL notmuch-fcc-dirs set to a list (catch-all) > --- T310-emacs.29.EXPECTED 2021-01-13 12:00:57.933429400 +0000 > +++ T310-emacs.29.OUTPUT 2021-01-13 12:00:57.933429400 +0000 > @@ -1,5 +0,0 @@ > -From: Notmuch Test Suite > -To: > -Subject: > -Fcc: /home/bremner/software/upstream/notmuch/test/tmp.T310-emacs/mail/sent-list-catch-all > ---text follows this line-- > *ERROR*: Wrong type argument: listp, "failure" > FAIL notmuch-fcc-dirs set to a list (no match) > --- T310-emacs.30.EXPECTED 2021-01-13 12:00:57.953429900 +0000 > +++ T310-emacs.30.OUTPUT 2021-01-13 12:00:57.957430000 +0000 > @@ -1,4 +0,0 @@ > -From: Notmuch Test Suite > -To: > -Subject: > ---text follows this line-- > *ERROR*: Wrong type argument: listp, "failure" > _______________________________________________ > notmuch mailing list -- notmuch@notmuchmail.org > To unsubscribe send an email to notmuch-leave@notmuchmail.org