From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id mF+dCxbYKmBNZgAA0tVLHw (envelope-from ) for ; Mon, 15 Feb 2021 20:22:46 +0000 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id qE5rBxbYKmCAAgAA1q6Kng (envelope-from ) for ; Mon, 15 Feb 2021 20:22:46 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6726E1B525 for ; Mon, 15 Feb 2021 21:22:45 +0100 (CET) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 19FC41FBA7; Mon, 15 Feb 2021 15:22:36 -0500 (EST) Received: from lahtoruutu.iki.fi (lahtoruutu.iki.fi [185.185.170.37]) by mail.notmuchmail.org (Postfix) with ESMTPS id B288A1FAEF for ; Mon, 15 Feb 2021 15:22:32 -0500 (EST) Received: from guru.guru-group.fi (unknown [IPv6:2a02:2380:1:9:5054:ff:feb7:a4bc]) (using TLSv1.2 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: too) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id 315381B001E8; Mon, 15 Feb 2021 22:22:29 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1613420549; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=C5u2tJQ4wlCDFuv7CEYemQttMGWkmBNGfzACfgwkYu8=; b=u+UMvpX06MIbi30VEi+sa8tPGW4J7JSeI3KnO4mKB9rfRZbeS/KwKfd+1Ts0g1iVofcoQB 5hv+f1k5tA8zS+NKsK5usiNpTrFK1bgnRmYR/Q3yYntdU3KQPTGHBSKhl0WXZD1TBBaNbv /UWC7iYCRK8gB9s+yFZYEorgaNwKjBIgjy+rKLzy5kl8ucRpwki7YbUhuMgTQ/cujNVVLr Q5S8T9dt8hlbrds4Czo9VacrcTRvXuOEdFrSXyKv05ssJMfEYq9CwU2TFzuDZJcPmiTO1R RT2s1EUTPrLMW54sMj4Gm2fmG9vbaVM7AQAJi2uE4ecv01fXOppednSictvUrg== From: Tomi Ollila To: David Bremner , notmuch@notmuchmail.org Cc: David Bremner Subject: Re: [PATCH 2/2] lib: use a stricter unused macro In-Reply-To: <20210215023153.4069790-2-david@tethera.net> References: <20210215023153.4069790-1-david@tethera.net> <20210215023153.4069790-2-david@tethera.net> User-Agent: Notmuch/0.31.3+85~g92bd77f (https://notmuchmail.org) Emacs/27.1 X-Face: HhBM'cA~ MIME-Version: 1.0 ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=too smtp.mailfrom=tomi.ollila@iki.fi ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1613420549; a=rsa-sha256; cv=none; b=GWjgzgH3gwXED0+62yTjDwmnNwwzTcVlsEEobFYf+0mR0kpto1c1Tt5h6FIJo/OgPFL+wA 04aKdU3v/Knb44Z/HaALAhlGPcdqyDUiqP8ulIOpMVYqzXuwcTTCOImsIYztFN6S+KHs8T hg9bZWFnuzh+3HLe8rVFXy1GJIKHxKu9+1ibBG+Uj75URmHj/d0x4m3FQl9RuXEXXPqjNx uW35foanf2bbZ31z6DTQ0ygh3lIH8WbBL826IMcWliamK4HQSfOoA+W1Wc8OTKtL4k0byM VaUDAykX37jt9dJZHZ7FP+cgRY9nnrsZyXunVHSj//qJcJ1TQTFKTnWtX7pv6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1613420549; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=C5u2tJQ4wlCDFuv7CEYemQttMGWkmBNGfzACfgwkYu8=; b=DHdSZRtFhCIJCYN98vlgDmfJwuazPBFdk4FmUMW6D3GI8ZKksCb4x3tT/n1e7LbvfWWA1Z SMGD5+SEpNwCmOOt1ehJISdDD5zYfN7+R14DRPNVYof3r1Lnrg4pqAhWYwoOlQHTL8QefT j/IQmg8pUnHmDL99oQWNj1C7cZK7GB9o3WdstfKFgtxZkCLMECKzftaWyybnlGg1sjZJ8z kfDZ8cQVw9OLPZQ92vjlGzw3j4J6kfzJK18+7fansMdoRtJdnj5sG/ievllsVB5auROLsy rM7h830knoJtze2H+wLMqVWq2mn8QqR7GYvHaUbr5c+Ee1Q+/PnY1m2QPr/zoQ== Message-ID-Hash: CF7R7PGBLSQU2OR3LBOBH7UTI2O4NKAC X-Message-ID-Hash: CF7R7PGBLSQU2OR3LBOBH7UTI2O4NKAC X-MailFrom: tomi.ollila@iki.fi X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: 2.53 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=lahtoruutu header.b=u+UMvpX0; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 6726E1B525 X-Spam-Score: 2.53 X-Migadu-Scanner: scn0.migadu.com X-TUID: 3RWQrhDKgW0V On Sun, Feb 14 2021, David Bremner wrote: > This would have caught bugs like the one corrected in the previous > commit. Series LGTM. Tomi > --- > lib/notmuch-private.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/notmuch-private.h b/lib/notmuch-private.h > index 2fbf7ab9..2f5ccd6a 100644 > --- a/lib/notmuch-private.h > +++ b/lib/notmuch-private.h > @@ -76,7 +76,7 @@ NOTMUCH_BEGIN_DECLS > #define NOTMUCH_CLEAR_BIT(valp, bit) \ > (_NOTMUCH_VALID_BIT (bit) ? (*(valp) &= ~(1ull << (bit))) : *(valp)) > > -#define unused(x) x __attribute__ ((unused)) > +#define unused(x) x ## _unused __attribute__ ((unused)) looks familiar ;D > > /* Thanks to Andrew Tridgell's (SAMBA's) talloc for this definition of > * unlikely. The talloc source code comes to us via the GNU LGPL v. 3. > -- > 2.30.0