From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Cc: David Bremner <david@tethera.net>
Subject: Re: [PATCH 2/2] lib: use a stricter unused macro
Date: Mon, 15 Feb 2021 22:22:25 +0200 [thread overview]
Message-ID: <m2eehhaxoe.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <20210215023153.4069790-2-david@tethera.net>
On Sun, Feb 14 2021, David Bremner wrote:
> This would have caught bugs like the one corrected in the previous
> commit.
Series LGTM.
Tomi
> ---
> lib/notmuch-private.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/notmuch-private.h b/lib/notmuch-private.h
> index 2fbf7ab9..2f5ccd6a 100644
> --- a/lib/notmuch-private.h
> +++ b/lib/notmuch-private.h
> @@ -76,7 +76,7 @@ NOTMUCH_BEGIN_DECLS
> #define NOTMUCH_CLEAR_BIT(valp, bit) \
> (_NOTMUCH_VALID_BIT (bit) ? (*(valp) &= ~(1ull << (bit))) : *(valp))
>
> -#define unused(x) x __attribute__ ((unused))
> +#define unused(x) x ## _unused __attribute__ ((unused))
looks familiar ;D
>
> /* Thanks to Andrew Tridgell's (SAMBA's) talloc for this definition of
> * unlikely. The talloc source code comes to us via the GNU LGPL v. 3.
> --
> 2.30.0
next prev parent reply other threads:[~2021-02-15 20:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-15 2:31 [PATCH 1/2] lib/open: remove incorrect unused attribute David Bremner
2021-02-15 2:31 ` [PATCH 2/2] lib: use a stricter unused macro David Bremner
2021-02-15 20:22 ` Tomi Ollila [this message]
2021-02-15 20:42 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2eehhaxoe.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).