From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id iN3eBrC2jWBDBwEAgWs5BA (envelope-from ) for ; Sat, 01 May 2021 22:14:40 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id oMCSArC2jWCpDAAAB5/wlQ (envelope-from ) for ; Sat, 01 May 2021 20:14:40 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B724018AAD for ; Sat, 1 May 2021 22:14:39 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 84025271D4; Sat, 1 May 2021 16:14:37 -0400 (EDT) Received: from lahtoruutu.iki.fi (lahtoruutu.iki.fi [185.185.170.37]) by mail.notmuchmail.org (Postfix) with ESMTPS id 7571F27182 for ; Sat, 1 May 2021 16:14:34 -0400 (EDT) Received: from guru.guru-group.fi (unknown [IPv6:2a02:2380:1:9:5054:ff:feb7:a4bc]) (using TLSv1.2 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: too) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id DB6E51B0102A; Sat, 1 May 2021 23:14:32 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1619900072; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bTVtgi1D5mXvcLlx/I5SHyQsogi/dLjv2UnUaOFYMPk=; b=CD9TLF7Tge+U558HTyeS0ZRYUmGiuX60t7O97Llg46hzL1stAhzur7Pg1mfztcqlQ79O7C l10cZmR9m3x/gemdpPk7LhhxjssEwmAfuZTF1VOoRR28DKclgNMKQ84WxwtlsRNVAihEXD +SpWoIVu8MLpgO8DhIInBoQmpjvz7i0+WJPRTu/L1o890aMJO/T5cfjs/FzOzuCHeluB8i vgu5nkxn8qdw8LhbbVOURvyHSL7wEJypB6FsBAt9OMK7z8S3GIT8PKUG96hnY5ou5WruKP oP1UOZEgXKTRLDWBkfBoW0Mcog2FzFqAlhmb05HP5SgSt3dJgz998s+kQi+2mA== From: Tomi Ollila To: Felipe Contreras , notmuch@notmuchmail.org Subject: Re: [PATCH 04/13] test: use correct fqdn in passwd_sanitize() In-Reply-To: <20210501115422.483314-5-felipe.contreras@gmail.com> References: <20210501115422.483314-1-felipe.contreras@gmail.com> <20210501115422.483314-5-felipe.contreras@gmail.com> User-Agent: Notmuch/0.31.4+128~gc67b63a (https://notmuchmail.org) Emacs/27.1 X-Face: HhBM'cA~ MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1619900072; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bTVtgi1D5mXvcLlx/I5SHyQsogi/dLjv2UnUaOFYMPk=; b=BeM4kT10i9rltuiBD3R+B43xBXeai89ZH37xrR1QwT5fTZ4hWyvKR9WcIkjY5UoOt/FYuj frxUbIwP4WmAmb3YoZrnC1WWi8KZpwo1z4aBDI08b2R2NkWDucFQuzzgHZZ3c9Y3Ebc72M kulh3jeq/OPud+FolPke/YR5J2Q/l1Fm5ZzdA7ulDI6qEIcKD9y/klH6NUi9I/1Z/f9s/G Z5RS7stbKuUmhRcSxEgyOVpPGmUJE3lO1Smg3S0wVhSDMZqm3Z/h2MxQTmrZChA3lbnKad DuNWxyrDr5JtIH6ek+9qiav7qKluYxg9MCfvvfqIDDYleu/AvVp2tOx5wnx7tA== ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=too smtp.mailfrom=tomi.ollila@iki.fi ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1619900072; a=rsa-sha256; cv=none; b=SiRkS76vYz6+JiOFNI0ZIeBWdXJIs26w6+O8S5KztA0e7KNLZ6WU1iwEqoQyGsnZry/4PD dDgjGyxPNMKfwEbwxCaUgAtSFhuRBetgKE1olinW/XgKZ1K7G72aAOA18ekgqsy01K3iiw Tw4kh2mkdZWtRzuylT6uqp0LangRNj1J2wlQ6YOSoS+cYCU08ceE4JFueG30DCwq4HD13R fExeh4Q/M8MxxaAg95Jp2wO2diOo4iDiepq5KcWT3CY7HSgcKXY9VVntHdxlFWAKdCv16u L/wMdno+BaYpRUSLo7TlnSMiR6rISNYTWMlBDHV7ur3AcDskbwTV35uG+VMW4w== Message-ID-Hash: NFWXOJK6JGMX2K7PPPITGIM4H2CHGSST X-Message-ID-Hash: NFWXOJK6JGMX2K7PPPITGIM4H2CHGSST X-MailFrom: tomi.ollila@iki.fi X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Daniel Kahn Gillmor X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619900079; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=AXJ5UXECxxm/0smFM4VjaYj8J4tcKNJXNwbEGankcys=; b=HANvCJvEhFjfU3+dcoXuXz2ZZ+25jbTGc/Yi2ldBHIZr7iTM3xLvV1zxbx8S5I6whrgt4e IYHkerOWrxR4jr9OTiP/0R1M9uLH3TsJqFhReNU+Xn0yZPKRH/NkrfpimaOgBAVkf1Kv5q KNuXkCAXol5AB0O2LO/y4B9P1cXh4K1ls6FGrB3I00llu797O6b8/wni2n8BJAZzNYFmpj 8inRxroiRKrB9xb2Z3G151Xi49VDNmjI82dHTGOsIasksZXM9Oa2SO5I1ey7ILZ9aINc8a K6BxbfZ9pG1G4gyJw4S35CqK5usVEuqQKOehMT0xwNCdnUmWGbHhYe97XMS0uQ== ARC-Seal: i=2; s=key1; d=yhetil.org; t=1619900079; a=rsa-sha256; cv=fail; b=uhZ1rbezYWC0YHsyeE2IGWjqAfGJHwWFtmYlFmBHfEPLyNOSDlxYMJ0Mn9r9fRRHG4/B3l kCQ5rEt5wEQXIUq0navWXLF4Qi06APUzufhQ15kX/UH6PJzCP5u+sXA6FnQMN7g10yON1o 3E2kuQWOF0nz10iuX3Na4+pMXdgp9SOL9tovTdo31Xofp09hUVFNhHTQnoaIBZgV3v2ddK /vsnOVHm0K1bz2UF23zXOoU1EQr64+TebWKPDXM5qwX+M209mxvZ4JEA4Bh3++Vew76AlN frWQkfx7MqFjhwEvfO4RZCefa8szOcq+fkSD7XxbmPmGkxlwPLL8BFGnNP/KyA== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=lahtoruutu header.b=CD9TLF7T; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: 0.94 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=lahtoruutu header.b=CD9TLF7T; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: B724018AAD X-Spam-Score: 0.94 X-Migadu-Scanner: scn0.migadu.com X-TUID: B/3wCA7Tay/a On Sat, May 01 2021, Felipe Contreras wrote: > My fqdn is 'natae.localdomain', however, socket.getfqdn() returns > 'localhost'. > > To fetch the true fqdn we need socket.getaddrinfo(). > > For more information see: https://stackoverflow.com/a/11580042/10474 > > Signed-off-by: Felipe Contreras > --- > test/test-lib.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/test/test-lib.sh b/test/test-lib.sh > index ae653363..21dda265 100644 > --- a/test/test-lib.sh > +++ b/test/test-lib.sh > @@ -709,7 +709,7 @@ import os, sys, pwd, socket > pw = pwd.getpwuid(os.getuid()) > user = pw.pw_name > name = pw.pw_gecos.partition(",")[0] > -fqdn = socket.getfqdn() > +fqdn = socket.getaddrinfo(socket.gethostname(), 0, 0, socket.SOCK_STREAM, 0, socket.AI_CANONNAME)[0][3] I trust you this works better. LGTM. Tomi