unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>, David Edmondson <dme@dme.org>,
	notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: update coolj-line-prefix-regexp to make space optional
Date: Wed, 29 Dec 2021 19:47:16 +0200	[thread overview]
Message-ID: <m2ee5vjobf.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <20211225233112.3364167-1-david@tethera.net>

On Sat, Dec 25 2021, David Bremner wrote:

> Jani reported that lines prefixed with '>' (as opposed to '> ') are
> not highlighted properly [1]. David E responded with a updated regex
> [2]. This change implements David E's suggestion.
>
> [1]: id:87a8b5pcky.fsf@nikula.org
> [2]: id:m2pok1e3gv.fsf@dme.org

LGTM.

Tomi

> ---
>  emacs/coolj.el | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/emacs/coolj.el b/emacs/coolj.el
> index d820525b..79d2a1b7 100644
> --- a/emacs/coolj.el
> +++ b/emacs/coolj.el
> @@ -45,7 +45,7 @@ Otherwise respect `fill-column'."
>    :group 'coolj
>    :type 'boolean)
>  
> -(defcustom coolj-line-prefix-regexp "^\\(>+ \\)*"
> +(defcustom coolj-line-prefix-regexp "^\\(>+ ?\\)*"
>    "Regular expression that matches line prefixes."
>    :group 'coolj
>    :type 'regexp)
> -- 
> 2.34.1

  reply	other threads:[~2021-12-29 17:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-05 18:48 [BUG] notmuch-emacs highlights '>' quoted wrapped lines incorrectly Jani Nikula
2017-01-05 19:01 ` David Edmondson
2017-01-06 10:30   ` Tomi Ollila
2017-01-06 10:46     ` David Edmondson
2017-01-06 11:26       ` Tomi Ollila
2021-12-25 23:31         ` [PATCH] emacs: update coolj-line-prefix-regexp to make space optional David Bremner
2021-12-29 17:47           ` Tomi Ollila [this message]
2021-12-29 18:26           ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2ee5vjobf.fsf@guru.guru-group.fi \
    --to=tomi.ollila@iki.fi \
    --cc=david@tethera.net \
    --cc=dme@dme.org \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).