From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Edmondson <dme@dme.org>,
Jameson Graef Rollins <jrollins@finestructure.net>,
Dmitry Kurochkin <dmitry.kurochkin@gmail.com>,
notmuch@notmuchmail.org
Subject: Re: [PATCH] test: make test_expect_equal_file() arguments flexible
Date: Thu, 02 Feb 2012 17:25:19 +0200 [thread overview]
Message-ID: <m2d39xb6lc.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <cuny5sl5mp7.fsf@hotblack-desiato.hh.sledj.net>
On Thu, 02 Feb 2012 14:33:56 +0000, David Edmondson <dme@dme.org> wrote:
> On Wed, 01 Feb 2012 09:24:32 -0800, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
> > If this is really a problem, I vote for 1. In general, I am not in
> > favor of making the test suite more complicated than it needs to be.
>
> After listening to the debate, I agree. The documentation should state
> that the order is 'expected actual' (or the other way around) and
> offenders should be shot on sight^W^W^Wfixed.
I've started to agree with Dmitry.
Why do something that computer can do -- to guide test writers to
give args in consistent order and provide suitable filenames.
Secondly as the output files are provided for human consumption
if there is consistent naming in expected output files helps
developers getting parts of the big picture easier and finding
right filenames easier.
... and the reviewers doesn't need to keep their plasma guns
handly.
Tomi
next prev parent reply other threads:[~2012-02-02 15:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-01 7:19 [PATCH] test: make test_expect_equal_file() arguments flexible Dmitry Kurochkin
2012-02-01 8:12 ` David Edmondson
2012-02-01 8:47 ` Jameson Graef Rollins
2012-02-01 8:55 ` Tomi Ollila
2012-02-01 9:23 ` Dmitry Kurochkin
2012-02-01 9:19 ` Dmitry Kurochkin
2012-02-01 10:18 ` Tomi Ollila
2012-02-01 10:37 ` Dmitry Kurochkin
2012-02-01 17:24 ` Jameson Graef Rollins
2012-02-01 23:42 ` Dmitry Kurochkin
2012-02-02 0:07 ` Dmitry Kurochkin
2012-02-02 14:33 ` David Edmondson
2012-02-02 15:25 ` Tomi Ollila [this message]
2012-02-02 17:40 ` Jameson Graef Rollins
2012-09-02 2:38 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2d39xb6lc.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=dme@dme.org \
--cc=dmitry.kurochkin@gmail.com \
--cc=jrollins@finestructure.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).