From: Tomi Ollila <tomi.ollila@iki.fi>
To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2 0/7] cli: better tooling support for duplicate messages
Date: Mon, 10 Jun 2013 18:30:18 +0300 [thread overview]
Message-ID: <m2d2ru6l11.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <cover.1370775663.git.jani@nikula.org>
On Sun, Jun 09 2013, Jani Nikula <jani@nikula.org> wrote:
> v2 of id:cover.1368467532.git.jani@nikula.org
>
> The only change is switching to 1-based indexing for --duplicate=N
> option.
The code looks good to me. Mark's comment about showing duplicate file
from another folder than mentioned in query string could be tackled
in manual somehow.
Also, when you make next version fix the commit message in
id:61ed86f221d65b4dba438cbc2b4c5b77a484a534.1370775663.git.jani@nikula.org
to mention 1-based.
> Jani.
Tomi
BTW: can we track on which machine you're working on by looking
Message-Id:s >;)
>
>
> Jani Nikula (7):
> cli: add --duplicate=N option to notmuch search
> test: test notmuch search --duplicate=N
> man: document notmuch search --duplicate=N
> cli: add --output=files option to notmuch count
> test: test notmuch count --output=files
> man: document notmuch count --output=files
> NEWS: cli options for improved duplicate message handling
>
> NEWS | 12 +++++++++
> man/man1/notmuch-count.1 | 10 ++++++-
> man/man1/notmuch-search.1 | 11 ++++++++
> notmuch-count.c | 37 ++++++++++++++++++++++++++
> notmuch-search.c | 18 ++++++++-----
> test/count | 10 +++++++
> test/search-output | 65 +++++++++++++++++++++++++++++++++++++++++++++
> 7 files changed, 156 insertions(+), 7 deletions(-)
>
> --
> 1.7.10.4
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
prev parent reply other threads:[~2013-06-10 15:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-09 11:03 [PATCH v2 0/7] cli: better tooling support for duplicate messages Jani Nikula
2013-06-09 11:03 ` [PATCH v2 1/7] cli: add --duplicate=N option to notmuch search Jani Nikula
2013-06-09 20:22 ` Mark Walters
2013-06-10 16:49 ` Jani Nikula
2013-06-10 15:57 ` [PATCH v3] " Jani Nikula
2013-06-09 11:03 ` [PATCH v2 2/7] test: test notmuch search --duplicate=N Jani Nikula
2013-06-09 11:03 ` [PATCH v2 3/7] man: document " Jani Nikula
2013-06-09 13:20 ` Mark Walters
2013-06-09 13:25 ` Mark Walters
2013-06-10 16:39 ` Jani Nikula
2013-06-10 16:28 ` [PATCH v3] " Jani Nikula
2013-06-09 11:03 ` [PATCH v2 4/7] cli: add --output=files option to notmuch count Jani Nikula
2013-06-09 11:03 ` [PATCH v2 5/7] test: test notmuch count --output=files Jani Nikula
2013-06-09 11:03 ` [PATCH v2 6/7] man: document " Jani Nikula
2013-06-09 11:03 ` [PATCH v2 7/7] NEWS: cli options for improved duplicate message handling Jani Nikula
2013-06-10 15:30 ` Tomi Ollila [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2d2ru6l11.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=jani@nikula.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).